You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/15 11:13:10 UTC
[GitHub] [incubator-nuttx] PetervdPerk-NXP opened a new pull request #1238: Net: SocketCAN support
PetervdPerk-NXP opened a new pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238
## Summary
Adds support for the SocketCAN interface api to Nuttx (https://en.wikipedia.org/wiki/SocketCAN)
Furthermore it includes FlexCAN drivers for S32K1XX and Kinetis which are SocketCAN compatible
Additional changes:
Control messages (CMSG) support for sendmsg() and recvmsg() (POSIX 1003.1g)
SIOCGIFNAME & SIOCGIFNAME ioctl
## Impact
Quite big, changes in NET, libc/net,
## Testing
Verified on rddrone-uavcans32k146 (S32K146) & rddrone-fmuk66 (Kinetis K66).
Furthermore this patch has already been backported to PX4/NuttX where they verified using their CI that this patch doesn't break any boards using the network stack.
## Additional information
This patch requires changes in apps to support AF_CAN in netlib. I will make a PR for that as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644133498
There are quite a few build problems... most warnings that are treated as errors. These all need to be fixed before we can merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644076318
Hi Peter,
Nice to see finally the SocketCAN coming to master branch!
It appears that you forgot to run nxstyle against the files. It stopped because found many 'long lines' in the file arch/arm/src/kinetis/hardware/kinetis_flexcan.h.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] PetervdPerk-NXP commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
PetervdPerk-NXP commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644096143
I've fixed the warnings now as well. For the remainder of files that are now giving a NXStyle error, I don't have nice and clean solution for them.
For these files I can't change header:
include/nuttx/can/error.h
include/nuttx/net/ioctl.h
For this file net/devif/devif_poll.c it's existing code (which I haven't changed) with a printf which exceeds the character limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644136844
Hmmm... but I can't merge because there are conflicts 8(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo merged pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644136110
PROBLEM: I already merged the companion companion PR in apps/ the companion failed to build because dependencies on this PR. But this PR should not be merged now because of real build problems. This think we have no option but to merge this now and fix the problems separately. Otherwise, the build will be broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] PetervdPerk-NXP edited a comment on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
PetervdPerk-NXP edited a comment on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644079679
I did but I wasn't sure what to do with the warnings, since I didn't change these particular lines. this is the output I got
`hovergames@hovergames:~/nuttx/nuttx-master$ ./tools/nxstyle arch/arm/src/kinetis/hardware/kinetis_flexcan.h
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:74:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:75:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:76:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:77:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:78:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:79:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:80:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:81:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:82:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:83:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:84:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:85:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:86:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:87:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:88:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:89:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:181:46: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:231:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:232:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:233:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:234:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:235:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:236:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:237:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:238:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:239:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:240:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:241:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:242:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:243:45: warning: Wrong column position of comment right of code
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644164194
I will remove the old SocketCAN branch now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644133725
This PR includes 3rd party code. We will need to update the LICENSE file. We can do that after the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] PetervdPerk-NXP commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
PetervdPerk-NXP commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644079679
I did but I wasn't sure what to do with the warnings, this is the output I got
`hovergames@hovergames:~/nuttx/nuttx-master$ ./tools/nxstyle arch/arm/src/kinetis/hardware/kinetis_flexcan.h
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:74:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:75:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:76:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:77:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:78:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:79:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:80:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:81:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:82:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:83:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:84:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:85:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:86:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:87:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:88:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:89:43: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:181:46: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:231:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:232:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:233:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:234:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:235:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:236:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:237:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:238:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:239:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:240:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:241:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:242:45: warning: Wrong column position of comment right of code
arch/arm/src/kinetis/hardware/kinetis_flexcan.h:243:45: warning: Wrong column position of comment right of code
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1238: Net: SocketCAN support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1238:
URL: https://github.com/apache/incubator-nuttx/pull/1238#issuecomment-644081411
> I did but I wasn't sure what to do with the warnings, since I didn't change these particular lines. this is the output I got
>
> `hovergames@hovergames:~/nuttx/nuttx-master$ ./tools/nxstyle arch/arm/src/kinetis/hardware/kinetis_flexcan.h arch/arm/src/kinetis/hardware/kinetis_flexcan.h:74:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:75:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:76:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:77:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:78:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:79:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:80:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:81:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:82:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:83:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:84:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:85:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:86:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:87:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:88:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:89:43: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:181:46: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:231:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:232:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:233:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:234:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:235:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:236:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:237:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:238:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:239:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:240:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:241:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:242:45: warning: Wrong column position of comment right of code arch/arm/src/kinetis/hardware/kinetis_flexcan.h:243:45: warning: Wrong column position of comment right of code `
You need to align the start of the comment block, they need to be visually aligned :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org