You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Daniel Sun (JIRA)" <ji...@apache.org> on 2019/05/07 15:19:00 UTC
[jira] [Updated] (GROOVY-9112) Clean bad smell in
`GroovyClassLoader`
[ https://issues.apache.org/jira/browse/GROOVY-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Sun updated GROOVY-9112:
-------------------------------
Description:
The type of {{classCache}} can not represent its true responsibility:
{{protected final Map<String, Class> classCache = new UnlimitedConcurrentCache<String, Class>();}}
So I propose to change the type to {{EvictableCache<String, Class>}}
Similarly, {{protected final Map<String, Class> sourceCache = new StampedCommonCache<String, Class>();}} has the same bad smell
It will be a breaking change, but it is time to clean the historical bad smell in a big version like Groovy 3.0.0
> Clean bad smell in `GroovyClassLoader`
> --------------------------------------
>
> Key: GROOVY-9112
> URL: https://issues.apache.org/jira/browse/GROOVY-9112
> Project: Groovy
> Issue Type: Improvement
> Reporter: Daniel Sun
> Assignee: Daniel Sun
> Priority: Major
>
> The type of {{classCache}} can not represent its true responsibility:
> {{protected final Map<String, Class> classCache = new UnlimitedConcurrentCache<String, Class>();}}
> So I propose to change the type to {{EvictableCache<String, Class>}}
> Similarly, {{protected final Map<String, Class> sourceCache = new StampedCommonCache<String, Class>();}} has the same bad smell
> It will be a breaking change, but it is time to clean the historical bad smell in a big version like Groovy 3.0.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)