[jira] [Closed] (ORC-1440) Check for protobuf config based module

["Dongjoon Hyun (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ORC-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun closed ORC-1440.
------------------------------

> Check for protobuf config based module
> --------------------------------------
>
>                 Key: ORC-1440
>                 URL: https://issues.apache.org/jira/browse/ORC-1440
>             Project: ORC
>          Issue Type: Improvement
>          Components: build
>            Reporter: Nehal Jagdish Wani
>            Assignee: Nehal Jagdish Wani
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: failure.win.txt
>
>
> {*}What{*}:
> At the moment, the build on Windows fails with: [^failure.win.txt]
> {*}Why{*}:
> The recent version of `libprotobuf` generates code that depends on `abseil`. It can lead to issues for downstream consumers of the library. Example: [https://github.com/protocolbuffers/protobuf/issues/11920]
> {*}Potential Resolution{*}:
> The `orc::protobuf` interface target depends on our hand-rolled find module for `libprotobuf`. The recent versions of `libprotobuf` provide their own CMake configs. We can check for the existence of the config and use the hand-rolled version as a fallback.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)