You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/04/15 16:34:36 UTC
Review Request 33218: shell.call and shell.checked_call should be
always mocked in RMFTestCase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33218/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-10501
https://issues.apache.org/jira/browse/AMBARI-10501
Repository: ambari
Description
-------
shell.call and shell.checked_call should be always mocked in RMFTestCase in
order to avoid environment dependent unit test failures.
Diffs
-----
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 2c0c9f6
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 32a3ae3
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py bc15f3f
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ddfff2f
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 06480b7
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 6623fbe
ambari-server/src/test/python/stacks/utils/RMFTestCase.py 2e4b30f
Diff: https://reviews.apache.org/r/33218/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 33218: shell.call and shell.checked_call should be
always mocked in RMFTestCase
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33218/#review80185
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 15, 2015, 2:34 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33218/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 2:34 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-10501
> https://issues.apache.org/jira/browse/AMBARI-10501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> shell.call and shell.checked_call should be always mocked in RMFTestCase in
> order to avoid environment dependent unit test failures.
>
>
> Diffs
> -----
>
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 2c0c9f6
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 32a3ae3
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py bc15f3f
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ddfff2f
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 06480b7
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 6623fbe
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py 2e4b30f
>
> Diff: https://reviews.apache.org/r/33218/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>