You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/08/10 07:17:11 UTC

[GitHub] [servicecomb-java-chassis] Matrix0xCC commented on a change in pull request #1600: [SCB-1691] Refactor registry module

Matrix0xCC commented on a change in pull request #1600:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1600#discussion_r467724251



##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -214,24 +280,163 @@ private static IpPort genPublishIpPort(String schema, IpPort ipPort) {
 
   public static List<MicroserviceInstance> findServiceInstance(String appId, String serviceName,
       String versionRule) {
-    return serviceRegistry.findServiceInstance(appId, serviceName, versionRule);
+    MicroserviceCache serviceCache = aggregateServiceRegistryCache.findServiceCache(
+        MicroserviceCacheKey.builder()

Review comment:
       这个是不兼容的修改？
   修改之后`versionRule`被忽略了，为何不直接去掉这个参数？
   这个类目前被业务使用，升级之后没有发现这个接口的功能变更，导致了一个问题。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org