You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Georg Henzler (JIRA)" <ji...@apache.org> on 2012/10/13 10:51:02 UTC
[jira] [Created] (FELIX-3711) Make more REST Urls available in UI
(componnet id/name and service pid is often not clickable)
Georg Henzler created FELIX-3711:
------------------------------------
Summary: Make more REST Urls available in UI (componnet id/name and service pid is often not clickable)
Key: FELIX-3711
URL: https://issues.apache.org/jira/browse/FELIX-3711
Project: Felix
Issue Type: New Feature
Components: Web Console
Affects Versions: webconsole-4.0.0
Reporter: Georg Henzler
Many REST urls already work if created manually, but are not yet available as links in the UI:
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
http://localhost:8080/system/console/components/com.test.scr.ClassB
It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475555#comment-13475555 ]
Georg Henzler edited comment on FELIX-3711 at 10/13/12 9:05 AM:
----------------------------------------------------------------
See attached a patch to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
Other than that the patch is tested and works fine!
was (Author: henzlerg):
See attached a patch to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
Other than that the patch works fine is tested! :-)
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481207#comment-13481207 ]
Felix Meschberger commented on FELIX-3711:
------------------------------------------
The ID Link is really identifying the bundle. This is the only link that uniquely identifies a bundle.
The bundle symbolic name link (other than not being available all the times for pre R4 bundles) is not unique: More than one bundle may have the same symbolic name.
The bundle symbolic name+version link is not unique either: Nowadays multiple bundles may be installed with the same bundle version and name (yet this requires special framework configuration to be supported).
So, in the end, for the purpose of the web console, we stick to bundle ID links as long as we want to refer to an exact bundle.
I don't say the symbolic name and symbolic name+version links are bad per se. I just don't want to use them as the primary links in the web console itself. As I said, I am ok with exposing them for different use cases (as you said bookmarks, docs, etc.).
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476090#comment-13476090 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
Maybe another question before we dive too deep into the discussion about the solution: Do you general agree, that it's worthwhile to have those REST URLs available in the web console?
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Attachment: org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(componnet id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Description:
Many REST urls already work if created manually, but are not yet available as links in the UI:
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
http://localhost:8080/system/console/components/com.test.scr.ClassB
It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
was:
Many REST urls already work if created manually, but are not yet available as links in the UI:
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
http://localhost:8080/system/console/components/com.test.scr.ClassB
It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefor it would be nice to not have to construct them manually.
> Make more REST Urls available in UI (componnet id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475555#comment-13475555 ]
Georg Henzler edited comment on FELIX-3711 at 10/13/12 9:02 AM:
----------------------------------------------------------------
See attached a patch to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
was (Author: henzlerg):
See attached a path to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481249#comment-13481249 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
Ok, let's go down the original path then. I'm happy enough if we get the PermaLinks in the UI :)
So my patchv2 should pretty much do the work (apart from the JSON refactoring). Also it would be great if we could include the Rest URLs for the components/configurations as provided in the patch.
One thing that was missing in the patch: To find out if the plugin org.apache.felix.webconsole.plugins.ds is installed, we could just get the the services references for org.apache.felix.webconsole.ConfigurationPrinter and check for getBundle().getSymbolicName(). This should be fairly save and not cause the problem you mentioned ("Checking for a plugin's existince from another plugin... which is error-prone should the plugin be refactored.") The symbolic name of the "org.apache.felix.webconsole.plugins.ds" shouldn't change that often?
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Attachment: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
patch v2: console base url not hardcoded anymore, ComponentConstants.XXX used.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480953#comment-13480953 ]
Georg Henzler edited comment on FELIX-3711 at 10/21/12 11:46 AM:
-----------------------------------------------------------------
Good point... but as both URLs continue to work (either with id and symbolicName:version) it would be also easy to decide when creating the links what URL to use. The bundles without symbolic ids get the "Bundle Id Link", all other bundles could get the REST URL link.
Doing this is actually really easy (see attached patch, 2 lines of code :))
was (Author: henzlerg):
Good point... but as both URLs continue to work (either with id and symbolicName:version) it would be also easy to decide when creating the links what URL to use. The bundles without symbolic ids get the "Bundle Id Link", all other bundles could get the REST URL link.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481249#comment-13481249 ]
Georg Henzler edited comment on FELIX-3711 at 10/22/12 8:01 AM:
----------------------------------------------------------------
Ok, let's go down the original path then. I'm happy enough if we get the PermaLinks in the UI :)
So my patchv2 should pretty much do the work (apart from the JSON refactoring). Also it would be great if we could include the Rest URLs for the components/configurations as provided in the patch.
One thing that was missing in the patch: To find out if the plugin org.apache.felix.webconsole.plugins.ds is installed, we could just get the the services references for org.apache.felix.webconsole.ConfigurationPrinter and check for getBundle().getSymbolicName(). This should be fairly safe and not cause the problem you mentioned ("Checking for a plugin's existince from another plugin... which is error-prone should the plugin be refactored.") The symbolic name of the "org.apache.felix.webconsole.plugins.ds" shouldn't change that often?
was (Author: henzlerg):
Ok, let's go down the original path then. I'm happy enough if we get the PermaLinks in the UI :)
So my patchv2 should pretty much do the work (apart from the JSON refactoring). Also it would be great if we could include the Rest URLs for the components/configurations as provided in the patch.
One thing that was missing in the patch: To find out if the plugin org.apache.felix.webconsole.plugins.ds is installed, we could just get the the services references for org.apache.felix.webconsole.ConfigurationPrinter and check for getBundle().getSymbolicName(). This should be fairly save and not cause the problem you mentioned ("Checking for a plugin's existince from another plugin... which is error-prone should the plugin be refactored.") The symbolic name of the "org.apache.felix.webconsole.plugins.ds" shouldn't change that often?
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475555#comment-13475555 ]
Georg Henzler edited comment on FELIX-3711 at 10/13/12 12:13 PM:
-----------------------------------------------------------------
See attached a patch to make REST URLs available for the most important spots, please note the following:
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
Other than that the patch is tested and works fine!
was (Author: henzlerg):
See attached a patch to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
Other than that the patch is tested and works fine!
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476113#comment-13476113 ]
Felix Meschberger commented on FELIX-3711:
------------------------------------------
> We have some html in the JSON already (Service ID-Link)..
I like your idea of adding link properties and would be ok to take up the refactoring. I think this sounds more expensive than it probably really is.
You gave good examples for the service link in the bundles. The bundle links (by ID, symbolic name, symbolic name/version) can easily be constructed on the client side in the JavaScript.
> Do you general agree, that it's worthwhile to have those REST URLs available in the web console?
Of course links are good. But I tend to prefer them to have a functionality. Just having links hanging around without any intrinsic functionality for the application sounds confusing to me.
Maybe we can come up with something like Confluence does, where you can get different types of links for a Confluence page (Confluence link, URL, short URL). So that you can get the configuration, component, service links by clicking a button ?
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476047#comment-13476047 ]
Felix Meschberger commented on FELIX-3711:
------------------------------------------
I understand your request, but I think the solution is not appropriate:
* Checking for a plugin's existince from another plugin (or the core by that matter) introduces a nasty back-coupling which is error-prone should the plugin be refactored.
* Linking to other plugins is problematic (and we only very reluctantly did it until now).
I think the BundleInfo approach sketched by FELIX-3140 is supperior (and should be generalized/extended to also cover other areas like:
* bundles linking to services and components
* components linking to their configuration
* components linking to services
* services linking to components
Finally, while I agree, that it would be helpful to have links to "self" other than by bundle ID, I think such links are a presentation task better done in the respective JavaScript file (e.g. bundles.js for the bundles list) and not the JSON generation. I'd prefer to have the JSONs HTML-free and just provide the raw data.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480953#comment-13480953 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
Good point... but as both URLs continue to work (either with id and symbolicName:version) it would be also easy to decide when creating the links what URL to use. The bundles without symbolic ids get the "Bundle Id Link", all other bundles could get the REST URL link.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Attachment: (was: org.apache.felix.webconsole.patch-for-FELIX-3711.patch)
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475580#comment-13475580 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
Hooking in the links via BundleInfo (as suggested in FELIX-3140) is IMHO only a workaround - the links should be available as "first level citizen" of the UI at the top of the page without need to install add-on components.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(componnet id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Attachment: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
See attached a path to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
> Make more REST Urls available in UI (componnet id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475555#comment-13475555 ]
Georg Henzler edited comment on FELIX-3711 at 10/13/12 9:03 AM:
----------------------------------------------------------------
See attached a patch to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
Other than that the patch works fine is tested! :-)
was (Author: henzlerg):
See attached a patch to make REST URLs available for the most important spots, please note the following:
* The "/system/console" strings are hardcoded at the moment (but should probably use the config from http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.internal.servlet.OsgiManager instead)
* "component.id" and "component.name" are hardcoded - there might be constants for it somewhere already
* If "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin" is not installed, the /system/console/components/xxx urls don't work - there should probably be a check if the the DS web console plugin is available
* The patch doesn't include any changes for "Apache Felix Web Console Service Component Runtime/Declarative Services Plugin", but it would be nice to make component id/name clickable there as well!
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(componnet id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Description:
Many REST urls already work if created manually, but are not yet available as links in the UI:
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
http://localhost:8080/system/console/components/com.test.scr.ClassB
It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefor it would be nice to not have to construct them manually.
was:
Many REST urls already work if created manually, but are not yet available as links in the UI:
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
http://localhost:8080/system/console/components/com.test.scr.ClassB
It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> Make more REST Urls available in UI (componnet id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefor it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477657#comment-13477657 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
I think Confluence is a slightly broader use case, as the users enter links themselves in a rich text editor. But maybe we should think about URL design in general before we proceed... let's compare the following:
http://localhost:4000/system/console/bundles/24
http://localhost:4000/system/console/bundles/org.apache.felix.webconsole:3.1.9.R1239093
Shouldn't we get rid of the number-id link altogether? What's the benefit of having them? Let's compare:
PRO: Id-Link:
- it's shorter
- makes bundle id quickly prominently available (but this info is rarely needed by an admin)
PRO: Rest-Link:
- Shows the real technical id of a bundle in the link
- Makes the Link bookmarkable across software deployments (bundle ids might change)
- Link can be used in Emails/Skype/Jira etc.
- Switch between DEV/INT/PROD environments can be done by just replacing the domain (we have bookmarklets to do this!)
- and eventually: My patch from above makes the REST link available for users that know they can click the symbolic name of the bundle, but making the REST links default would mean that everyone would automatically benefit from them!
What do you think? (I'm aware I might totally miss something as I don't know the web console as well as you do!)
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481225#comment-13481225 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
=> RE: "The bundle symbolic name+version link is not unique either: Nowadays multiple bundles may be installed with the same bundle version and name (yet this requires special framework configuration to be supported)"
This is really new to me that the name+version is not unique. What sort of "framework configuration" does this require? Do you have a link?
So I'm not sure, how many people use a setup where name+version is not unique (1% of the users? 30% of the users?). If it was the 1% I would still opt for the Rest Links only falling back to the id links iff the framework is configured to allow multiple symbolic ids with the same version (I assume it's easy enough to find out on bundle activate of the web console if this is configured).
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476089#comment-13476089 ]
Georg Henzler commented on FELIX-3711:
--------------------------------------
=> RE "presentation task better done in the respective JavaScript"
Not "polluting" the JSON with Html is a good point - so I agree a frontend js solution could be the better approach. Let's have a look at the JSON how it's currently delivered:
....
{ "key": "Bundle-SymbolicName", "value": "com.day.cq.wcm.cq-wcm-foundation" }
....
{ "key": "Service ID <a href='/system/console/services/797'>797</a>",
"value": [
"Types: javax.servlet.Servlet, javax.servlet.ServletConfig, java.io.Serializable",
"Service PID: com.day.cq.wcm.foundation.ParagraphServlet",
"Component Name: com.day.cq.wcm.foundation.ParagraphServlet",
"Component ID: 563",
"Vendor: Day Management AG"
] }
We have some html in the JSON already (Service ID-Link)... to get rid of it (and to support the new feature of this issue) we could refactor it as follows:
{ "key": "Bundle-SymbolicName", "label": "Symbolic Name", "value": "com.day.cq.wcm.cq-wcm-foundation", "link": "http://.... can be optional" }
....
{ "key": "service.id", "label": "Service ID", "link": "/system/console/services/797"
"value": [
...
{ "key": "component.name", "Label": "Component Name" com.day.cq.wcm.foundation.ParagraphServlet", "link": "http://.... can be optional" }
...
]}
But obviously this would mean a bit of refactoring on both JS and Java sides.
=> RE: "BundleInfo approach superior"
IMHO, this not the case - the BundleInfo mechanism would get a lot more complicated to be able to hook into the basic display of the bundle... I believe the links should be a "first level citizen" in the UI and not be provided by some sort of plugin mechanism.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Henzler updated FELIX-3711:
---------------------------------
Summary: Make more REST Urls available in UI (component id/name and service pid is often not clickable) (was: Make more REST Urls available in UI (componnet id/name and service pid is often not clickable))
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481239#comment-13481239 ]
Felix Meschberger commented on FELIX-3711:
------------------------------------------
This feature has been introduced in the OSGi Core R 4.3 specification; the framework property is "org.osgi.framework.bsnversion".
I don't know how much this is used. But I don't want to fuss and special case and just go the stable route for links inside the web console. This makes for simpler and clearer and less error-prone code.
So, as a compromise, I could also offer, that we render a link icon after the symbolic name and versions which contain your bookmark-able links.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch, org.apache.felix.webconsole.patch-make-rest-url-default-for-bundles.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3711) Make more REST Urls available
in UI (component id/name and service pid is often not clickable)
Posted by "Georg Henzler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477657#comment-13477657 ]
Georg Henzler edited comment on FELIX-3711 at 10/17/12 6:25 AM:
----------------------------------------------------------------
I think Confluence is a slightly broader use case, as the users enter links themselves in a rich text editor. But maybe we should think about URL design in general before we proceed... let's compare the following:
http://localhost:4000/system/console/bundles/24
http://localhost:4000/system/console/bundles/org.apache.felix.webconsole:3.1.9.R1239093
Shouldn't we get rid of the number-id link altogether? What's the benefit of having them? Let's compare:
PRO: Id-Link:
- it's shorter
- makes bundle id quickly prominently available (but this info is rarely needed by an admin)
PRO: Rest-Link:
- Shows the real technical id of a bundle in the link
- Makes the Link bookmarkable across software deployments (bundle ids might change)
- Link can be used in Emails/Skype/Jira etc.
- Switch between DEV/INT/PROD environments can be done by just replacing the domain (we have bookmarklets to do this!)
- and eventually: My patch from above makes the REST link available for users that know they can click the symbolic name of the bundle, but making the REST links default would mean that everyone would automatically benefit from them!
What do you think? (I'm aware I might totally miss something as I don't know the web console as well as you do!)
was (Author: henzlerg):
I think Confluence is a slightly broader use case, as the users enter links themselves in a rich text editor. But maybe we should think about URL design in general before we proceed... let's compare the following:
http://localhost:4000/system/console/bundles/24
http://localhost:4000/system/console/bundles/org.apache.felix.webconsole:3.1.9.R1239093
Shouldn't we get rid of the number-id link altogether? What's the benefit of having them? Let's compare:
PRO: Id-Link:
- it's shorter
- makes bundle id quickly prominently available (but this info is rarely needed by an admin)
PRO: Rest-Link:
- Shows the real technical id of a bundle in the link
- Makes the Link bookmarkable across software deployments (bundle ids might change)
- Link can be used in Emails/Skype/Jira etc.
- Switch between DEV/INT/PROD environments can be done by just replacing the domain (we have bookmarklets to do this!)
- and eventually: My patch from above makes the REST link available for users that know they can click the symbolic name of the bundle, but making the REST links default would mean that everyone would automatically benefit from them!
What do you think? (I'm aware I might totally miss something as I don't know the web console as well as you do!)
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3711) Make more REST Urls available in UI
(component id/name and service pid is often not clickable)
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480811#comment-13480811 ]
Valentin Valchev commented on FELIX-3711:
-----------------------------------------
In older (pre 4.0) OSGi specification, the symbolic name is missing and is not mandatory. But it's mandatory an OSGi r4 compliant framework to still work with older bundles.
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
> Key: FELIX-3711
> URL: https://issues.apache.org/jira/browse/FELIX-3711
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: webconsole-4.0.0
> Reporter: Georg Henzler
> Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services detail views.
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI to bring people with one click to the desired location, therefore it would be nice to not have to construct them manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira