You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/12 23:21:33 UTC
[GitHub] [cassandra-builds] josh-mckenzie opened a new pull request, #84: add slowest 100 tests to pytest output
josh-mckenzie opened a new pull request, #84:
URL: https://github.com/apache/cassandra-builds/pull/84
On each run, we can trivially add the slowest 100 runs to the test output to give us something to target with potential optimization, comparison to in-jvm dtest, or deprecation.
100 is... very arbitrary. 10 might be fine. Or 50. Or 0 so it prints all! No real opinion there.
In a similar vein to the JIRA on unit test runtimes being lopsided and hot-spotty: https://issues.apache.org/jira/browse/CASSANDRA-17371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] josh-mckenzie commented on pull request #84: add slowest 100 tests to pytest output
Posted by GitBox <gi...@apache.org>.
josh-mckenzie commented on PR #84:
URL: https://github.com/apache/cassandra-builds/pull/84#issuecomment-1312726491
hah! So what you're saying is this is redundant and would require more TLC to centralize. I'm good w/that so long as there's a place to work on this; I can also call it out on the project status updates. Maybe getting more focus on cleaning up CI will help push back against us accumulating more and more bloat in the suites.
Some of those runtimes on that linked page are... really really _really_ long.
<html>
<body>
<!--StartFragment-->
dtest-upgrade.upgrade_tests.cql_tests | 1 day 6 hr
-- | --
<br class="Apple-interchange-newline"><!--EndFragment-->
</body>
Can that be right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a diff in pull request #84: add slowest 100 tests to pytest output
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #84:
URL: https://github.com/apache/cassandra-builds/pull/84#discussion_r1020873590
##########
build-scripts/cassandra-dtest-pytest.sh:
##########
@@ -100,7 +100,7 @@ if [ "x${DTEST_SPLIT_CHUNK}" != "x" ] ; then
SPLIT_TESTS=$(split -n r/${DTEST_SPLIT_CHUNK} ${WORKSPACE}/test_list.txt)
fi
-PYTEST_OPTS="-vv --log-cli-level=DEBUG --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s"
+PYTEST_OPTS="-vv --durations=100 --log-cli-level=DEBUG --junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s"
Review Comment:
awesome idea!
note, this will be the slowest 100 in each split.
and… you can sort all tests by duration here: https://ci-cassandra.apache.org/job/Cassandra-4.1/lastSuccessfulBuild/testReport/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #84: add slowest 100 tests to pytest output
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on PR #84:
URL: https://github.com/apache/cassandra-builds/pull/84#issuecomment-1312779265
bq. Some of those runtimes on that linked page are... really really really long.
they'e accumulated, so you gotta drill down, which is kinda annoying as it hides what the longest test methods might actually be…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org