You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2003/11/22 19:00:41 UTC
[PATCH] *Credentials constructors are sloppy
I think that UserNamePasswordCredentials should not allow null user
name, as well as NTCredentials should not accept null NT domain and
host. Especially NTCredentials in its present form can be too
misleading. One may assume that feeding the constructor with null value
instead of a real domain name will *somehow* make it pick up the actual
Windows domain name, which is of course not the case.
If there are no objections raised by Tuesday next week, I'll commit the
patch as is.
Oleg
Re: [PATCH] *Credentials constructors are sloppy
Posted by Ortwin Glück <or...@nose.ch>.
Very much appreciated. Is there a reason for the public setters in this
class? I would favour immutable Credentials. I see no point in them
beeing mutable objects, it's not very OO.
Odi
Oleg Kalnichevski wrote:
> I think that UserNamePasswordCredentials should not allow null user
> name, as well as NTCredentials should not accept null NT domain and
> host. Especially NTCredentials in its present form can be too
> misleading. One may assume that feeding the constructor with null value
> instead of a real domain name will *somehow* make it pick up the actual
> Windows domain name, which is of course not the case.
>
> If there are no objections raised by Tuesday next week, I'll commit the
> patch as is.
>
> Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org
Re: [PATCH] *Credentials constructors are sloppy
Posted by Michael Becke <be...@u.washington.edu>.
Looks good to me.
Mike
On Nov 22, 2003, at 1:00 PM, Oleg Kalnichevski wrote:
> I think that UserNamePasswordCredentials should not allow null user
> name, as well as NTCredentials should not accept null NT domain and
> host. Especially NTCredentials in its present form can be too
> misleading. One may assume that feeding the constructor with null value
> instead of a real domain name will *somehow* make it pick up the actual
> Windows domain name, which is of course not the case.
>
> If there are no objections raised by Tuesday next week, I'll commit the
> patch as is.
>
> Oleg
> <creds.patch>----------------------------------------------------------
> -----------
> To unsubscribe, e-mail:
> commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
> commons-httpclient-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org