[GitHub] [pinot] jackjlli commented on pull request #8266: Move all prestodb dependencies into a separated module

[GitBox <gi...@apache.org>]

jackjlli commented on pull request #8266:
URL: https://github.com/apache/pinot/pull/8266#issuecomment-1055792453


   > > Currently Pinot at LinkedIn is partly on jdk 8, mainly on the offline ingestion part (very similar to the situation of Presto). And bumping up jdk version to 11 in the offline world is non-trivial since there are a lot dependencies/components that need to be Java 11 compatible (e.g. Hadoop 3.0+ needs to be used, etc). I also tried out the Pinot Java 11 compiled code in current offline env but since Java 8 is being used there, there is no way to run the Pinot Java 11 compiled code there (it's not allowed to run code compiled in higher jdk version in a lower jvm version). What's the plan for these jdk8 modules? Will they be left in Presto? If that's the case, we may also need some **extra** modules to be jdk 8 compatible.
   > 
   > For LinkedIn internal, you can always use the parameter to build JDK 8 binary code jars and publish them to internal artifactory. This change impacts maven that's why we have to separate the modules.
   
   Yes I understand the purpose of this PR, but what'd be the next steps? After splitting out to the separate modules, will the existing modules like `pinot-core` or `pinot-common` still be jdk 8 compatible? Will they be able to compile with parameters like `-Djdk.version=8`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org