You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/16 17:54:10 UTC

Review Request 20418: Flume: add agent pass-thru data

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20418/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-5479
    https://issues.apache.org/jira/browse/AMBARI-5479


Repository: ambari


Description
-------

* Required to pass information straight to an agent on a command.  The summary says Flume, but it could be any HostComponent.  For example, we need to start/stop a specific flume agent.
* Implemented only for standard and custom commands for now (to get restart capability).  Can revisit later with Actions if needed.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d55d965 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60d372c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py cdfd08c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b 
  ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json PRE-CREATION 

Diff: https://reviews.apache.org/r/20418/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:43.004s
[INFO] Finished at: Wed Apr 16 11:44:54 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 20418: Flume: add agent pass-thru data

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20418/#review40612
-----------------------------------------------------------


Ping!

- Nate Cole


On April 16, 2014, 11:54 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20418/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 11:54 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5479
>     https://issues.apache.org/jira/browse/AMBARI-5479
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Required to pass information straight to an agent on a command.  The summary says Flume, but it could be any HostComponent.  For example, we need to start/stop a specific flume agent.
> * Implemented only for standard and custom commands for now (to get restart capability).  Can revisit later with Actions if needed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d55d965 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60d372c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py cdfd08c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20418/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:43.004s
> [INFO] Finished at: Wed Apr 16 11:44:54 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 20418: Flume: add agent pass-thru data

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20418/#review40684
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On April 16, 2014, 3:54 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20418/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 3:54 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5479
>     https://issues.apache.org/jira/browse/AMBARI-5479
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Required to pass information straight to an agent on a command.  The summary says Flume, but it could be any HostComponent.  For example, we need to start/stop a specific flume agent.
> * Implemented only for standard and custom commands for now (to get restart capability).  Can revisit later with Actions if needed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d55d965 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 60d372c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py cdfd08c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20418/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:43.004s
> [INFO] Finished at: Wed Apr 16 11:44:54 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>