You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/06 12:01:38 UTC

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #352: interpreters: Add initial duktape support

no1wudi commented on a change in pull request #352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/352#discussion_r466361989



##########
File path: interpreters/duktape/Kconfig
##########
@@ -0,0 +1,20 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config INTERPRETERS_DUKTAPE
+	tristate "Duktape JavaScript interpreter"
+	default n
+
+if INTERPRETERS_DUKTAPE
+
+config INTERPRETERS_DUKTAPE_PRIORITY
+	int "Duktape interpreter priority"
+	default 100
+
+config INTERPRETERS_DUKTAPE_STACKSIZE
+	int "Duktape interpreter stack size"
+	default 8192

Review comment:
       In my test, the task stack size must greater than 6k to run REPL




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org