[jira] [Comment Edited] (GROOVY-9174) Change groovy-test-junit5 dependency on junit-platform-launcher to provided

["Paul King (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048119#comment-17048119 ] 

Paul King edited comment on GROOVY-9174 at 2/29/20 10:07 AM:
-------------------------------------------------------------

[~sbrannen] Can you check whether the groovy-test-junit5 pom as is being created for 3.0.2-SNAPSHOT meets your requirements:

[https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy-test-junit5/3.0.2-SNAPSHOT/]

This has only core groovy as a compile dependency and all other artifacts as runtime. This isn't provided as you requested but I believe should be able to work fine (perhaps needing an {{excludes}} adjustment).

Currently, we also bundle various junit jars in our distribution. This is to give users a working junit5 "out-of-the-box" experience.
 Bundling impacts users trying to {{@Grab}} different junit versions in their scripts but shouldn't impact gradle/maven users. Fixing that isn't about the pom but rather exclusions we'd put in our {{assemble.gradle}} file.


was (Author: paulk):
Can you check whether the groovy-test-junit5 pom as is being created for 3.0.2-SNAPSHOT meets your requirements:

https://oss.jfrog.org/artifactory/oss-snapshot-local/org/codehaus/groovy/groovy-test-junit5/3.0.2-SNAPSHOT/

This has only core groovy as a compile dependency and all other artifacts as runtime. This isn't provided as you requested but I believe should be able to work fine (perhaps needing an {{excludes}} adjustment).

Currently, we also bundle various junit jars in our distribution. This is to give users a working junit5 "out-of-the-box" experience.
Bundling impacts users trying to {{@Grab}} different junit versions in their scripts but shouldn't impact gradle/maven users. Fixing that isn't about the pom but rather exclusions we'd put in our {{assemble.gradle}} file.

> Change groovy-test-junit5 dependency on junit-platform-launcher to provided
> ---------------------------------------------------------------------------
>
>                 Key: GROOVY-9174
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9174
>             Project: Groovy
>          Issue Type: Improvement
>          Components: groovy-test-junit5
>    Affects Versions: 3.0.0-beta-1, 2.5.7
>            Reporter: Sam Brannen
>            Assignee: Eric Milles
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Please change the scope for the dependency on {{junit-platform-launcher}} from {{compile}} to {{provided}} in the POM for {{groovy-test-junit5}}.
> The {{compile}} dependency ends up on classpath in Gradle builds (at an older version) even if the rest of the JUnit Platform dependencies are included at a newer version.
> Related to GROOVY-9138.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)