You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2014/10/15 15:58:10 UTC

svn commit: r1632039 - /commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java

Author: ggregory
Date: Wed Oct 15 13:58:09 2014
New Revision: 1632039

URL: http://svn.apache.org/r1632039
Log:
Statement unnecessarily nested within else clause.

Modified:
    commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java

Modified: commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java?rev=1632039&r1=1632038&r2=1632039&view=diff
==============================================================================
--- commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java (original)
+++ commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java Wed Oct 15 13:58:09 2014
@@ -437,12 +437,9 @@ public class HtmlEmail extends MultiPart
             {
                 return ii.getCid();
             }
-            else
-            {
-                throw new EmailException("embedded DataSource '" + name
-                    + "' is already bound to name " + ii.getDataSource().toString()
-                    + "; existing names cannot be rebound");
-            }
+            throw new EmailException("embedded DataSource '" + name
+                + "' is already bound to name " + ii.getDataSource().toString()
+                + "; existing names cannot be rebound");
         }
 
         final String cid = EmailUtils.randomAlphabetic(HtmlEmail.CID_LENGTH).toLowerCase();