You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "agrawalreetika (via GitHub)" <gi...@apache.org> on 2023/12/12 07:04:48 UTC
[PR] Set HadoopFileIO as default for HadoopCatalog [iceberg]
agrawalreetika opened a new pull request, #9283:
URL: https://github.com/apache/iceberg/pull/9283
In case when we query the Hadoop catalog from [Presto](https://github.com/prestodb/presto), here we use [CatalogUtil.loadCatalog()](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/CatalogUtil.java#L216). If the catalog for Iceberg table is `Hadoop` here in [HadoopCatalog.initialize()](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java#L104) Catalog configuration as not being set via [HadoopFileIO.initialize()](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java#L81) but if fileIOImpl config is set explicitly then it creates HadoopFileIO object via [CatalogUtil.loadFileIO()](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/CatalogUtil.java#L301) which is also responsible of initialising Catalog configuration if supplied.
So here in this change we could do loadFileIO just like [NessieCatalog](https://github.com/apache/iceberg/blob/main/nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java#L123) which would also intialise HadoopFileIO catalog config even in case of HadoopCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431007132
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -221,6 +221,22 @@ public void testBasicCatalog() throws Exception {
Assertions.assertThat(fs.isDirectory(new Path(metaLocation))).isFalse();
}
+ @Test
+ public void testHadoopFileIOProperties() {
+ TableIdentifier tableIdent = TableIdentifier.of("db", "ns1", "ns2", "tbl");
+ ImmutableMap<String, String> catalogProps =
+ ImmutableMap.of(
+ "warehouse", "/hive/testwarehouse",
+ "io.manifest.cache-enabled", "true");
+
+ HadoopCatalog catalog = new HadoopCatalog();
+ catalog.initialize("hadoop", catalogProps);
+ FileIO fileIO = catalog.newTableOps(tableIdent).io();
+
+ Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse");
+ Assertions.assertThat(fileIO.properties().get("io.manifest.cache-enabled")).isEqualTo("true");
Review Comment:
```suggestion
Assertions.assertThat(fileIO.properties()).containsEntry("io.manifest.cache-enabled", "true");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "agrawalreetika (via GitHub)" <gi...@apache.org>.
agrawalreetika commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431230670
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -110,13 +110,18 @@ public void initialize(String name, Map<String, String> properties) {
this.catalogName = name;
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
+
+ if (conf == null) {
Review Comment:
@nastra If Hadoop Configuration is not set then subsequent would have NullPointer Excpetion. While adding the Tests I noticed we don't have conf check in `HadoopCatalog` the way we have it in `HiveCatalog`
I can explicitly initialize conf in my Tests if you think this check is not required here. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "agrawalreetika (via GitHub)" <gi...@apache.org>.
agrawalreetika commented on PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#issuecomment-1851439389
Thank you @ajantha-bhat for the details. I have made the changes in the Title and description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "yingsu00 (via GitHub)" <gi...@apache.org>.
yingsu00 commented on PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#issuecomment-1853905363
PR message "to Initialise" -> to initialize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431238389
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -110,13 +110,18 @@ public void initialize(String name, Map<String, String> properties) {
this.catalogName = name;
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
+
+ if (conf == null) {
Review Comment:
`conf` always needs to be set explicitly. This is because the `HadoopCatalog` (and a few others) implement `Configurable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431198610
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -110,13 +110,18 @@ public void initialize(String name, Map<String, String> properties) {
this.catalogName = name;
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
+
+ if (conf == null) {
Review Comment:
sorry I just saw this change now. Why do we need this? I think this should be reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "agrawalreetika (via GitHub)" <gi...@apache.org>.
agrawalreetika commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1426167674
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -112,11 +112,11 @@ public void initialize(String name, Map<String, String> properties) {
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
this.fs = Util.getFs(new Path(warehouseLocation), conf);
- String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO =
- fileIOImpl == null
- ? new HadoopFileIO(conf)
- : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ String fileIOImpl =
+ properties.getOrDefault(
+ CatalogProperties.FILE_IO_IMPL, "org.apache.iceberg.hadoop.HadoopFileIO");
+
+ this.fileIO = CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
Review Comment:
@amogh-jahagirdar Could you please provide me a reference of tests for the Nessie catalog? I can plan a similar tests for the Hadoop catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #9283:
URL: https://github.com/apache/iceberg/pull/9283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "agrawalreetika (via GitHub)" <gi...@apache.org>.
agrawalreetika commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1430965339
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -112,11 +112,11 @@ public void initialize(String name, Map<String, String> properties) {
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
this.fs = Util.getFs(new Path(warehouseLocation), conf);
- String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO =
- fileIOImpl == null
- ? new HadoopFileIO(conf)
- : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ String fileIOImpl =
+ properties.getOrDefault(
+ CatalogProperties.FILE_IO_IMPL, "org.apache.iceberg.hadoop.HadoopFileIO");
+
+ this.fileIO = CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
Review Comment:
Thank you for your input @amogh-jahagirdar
I have added a test for checking HadoopFileIO properties initialization. Also while adding tests, I noticed there is missing Null check for Hadoop config in `HadoopCatalog` so added that as well.
Please review the changes and let me know if any changes are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431007327
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -221,6 +221,22 @@ public void testBasicCatalog() throws Exception {
Assertions.assertThat(fs.isDirectory(new Path(metaLocation))).isFalse();
}
+ @Test
+ public void testHadoopFileIOProperties() {
+ TableIdentifier tableIdent = TableIdentifier.of("db", "ns1", "ns2", "tbl");
+ ImmutableMap<String, String> catalogProps =
+ ImmutableMap.of(
+ "warehouse", "/hive/testwarehouse",
+ "io.manifest.cache-enabled", "true");
+
+ HadoopCatalog catalog = new HadoopCatalog();
+ catalog.initialize("hadoop", catalogProps);
+ FileIO fileIO = catalog.newTableOps(tableIdent).io();
+
+ Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse");
Review Comment:
this is generally better, because if the assertion ever fails, it will show the content of properties()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431006756
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -221,6 +221,22 @@ public void testBasicCatalog() throws Exception {
Assertions.assertThat(fs.isDirectory(new Path(metaLocation))).isFalse();
}
+ @Test
+ public void testHadoopFileIOProperties() {
+ TableIdentifier tableIdent = TableIdentifier.of("db", "ns1", "ns2", "tbl");
+ ImmutableMap<String, String> catalogProps =
+ ImmutableMap.of(
+ "warehouse", "/hive/testwarehouse",
+ "io.manifest.cache-enabled", "true");
+
+ HadoopCatalog catalog = new HadoopCatalog();
+ catalog.initialize("hadoop", catalogProps);
+ FileIO fileIO = catalog.newTableOps(tableIdent).io();
+
+ Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse");
Review Comment:
```suggestion
Assertions.assertThat(fileIO.properties()).containsEntry("warehouse", "/hive/testwarehouse");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1430571350
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -112,11 +112,11 @@ public void initialize(String name, Map<String, String> properties) {
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
this.fs = Util.getFs(new Path(warehouseLocation), conf);
- String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO =
- fileIOImpl == null
- ? new HadoopFileIO(conf)
- : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ String fileIOImpl =
+ properties.getOrDefault(
+ CatalogProperties.FILE_IO_IMPL, "org.apache.iceberg.hadoop.HadoopFileIO");
+
+ this.fileIO = CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
Review Comment:
Sorry for the delay, it looks like Nessie Catalog does not really test that path (`TestNessieCatalog`) as far as I can tell but we don't necessarily need to follow the same here. I think we could add a test to `TestHadoopCatalog` which looks something like the following:
```
@ Test
public void testHadoopFileIOProperties() {
String warehouseLocation = tableDir.getAbsolutePath();
HadoopCatalog catalog = new HadoopCatalog();
catalog.setConf(new Configuration());
catalog.initialize(
"hadoop", ImmutableMap.of(CatalogProperties.WAREHOUSE_LOCATION, warehouseLocation, "some-file-io-property", "some-file-io-value"));
TableIdentifier tableIdent = TableIdentifier.of("db", "ns1", "ns2", "tbl");
catalog.buildTable(tableIdent, SCHEMA).withPartitionSpec(SPEC).create();
FileIO fileIO = catalog.newTableOps(tableIdent).io();
assertThat(fileIO.properties().get(CatalogProperties.WAREHOUSE_LOCATION)).equals(warehouseLocation)
assertThat(fileIO.properties().get("some-file-io-property)).equals("some-file-io.value")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431525886
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -112,11 +112,11 @@ public void initialize(String name, Map<String, String> properties) {
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
this.fs = Util.getFs(new Path(warehouseLocation), conf);
- String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO =
- fileIOImpl == null
- ? new HadoopFileIO(conf)
- : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ String fileIOImpl =
+ properties.getOrDefault(
+ CatalogProperties.FILE_IO_IMPL, "org.apache.iceberg.hadoop.HadoopFileIO");
+
+ this.fileIO = CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
Review Comment:
I don't think the conf change is needed as @nastra pointed out it should always be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#issuecomment-1862958670
Merged, thanks @agrawalreetika and thanks for reviews @nastra @ajantha-bhat !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Use properties while initializing default HadoopFileIO for Hadoop catalog. [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1425696907
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -112,11 +112,11 @@ public void initialize(String name, Map<String, String> properties) {
this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation);
this.fs = Util.getFs(new Path(warehouseLocation), conf);
- String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO =
- fileIOImpl == null
- ? new HadoopFileIO(conf)
- : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ String fileIOImpl =
+ properties.getOrDefault(
+ CatalogProperties.FILE_IO_IMPL, "org.apache.iceberg.hadoop.HadoopFileIO");
+
+ this.fileIO = CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
Review Comment:
Is it possible to add a test to validate that properties get set on the HadoopFileIO instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Set HadoopFileIO as default for HadoopCatalog [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#issuecomment-1851423776
@agrawalreetika: Previously also `HadoopFileIO` was default for HadoopCatalog.
I think only problem was properties was not considered for the default `HadoopFileIO` initilaization.
I expect PR title to be
```
Core: Use properties while initializing default HadoopFileIO for Hadoop catalog.
```
And a simple PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Set HadoopFileIO as default for HadoopCatalog [iceberg]
Posted by "agrawalreetika (via GitHub)" <gi...@apache.org>.
agrawalreetika commented on PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#issuecomment-1851415341
@nastra, Could you please help me with review on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org