[GitHub] [cassandra] maedhroz commented on pull request #1045: CASSANDRA-16663 Request-Based Native Transport Rate-Limiting

[GitBox <gi...@apache.org>]

maedhroz commented on pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#issuecomment-894963061


   @josh-mckenzie 
   
   > Permit allocation and freeing for the rate limiter (you have a couple TODO to this effect in the codebase as well)
   
   I think these are the two places where we're able to grab a permit against the rate limiter, but then immediately hit the limit on bytes in flight. (This seems like a pretty esoteric case within the already non-default throw-on-overload case, so I had left figuring out what to do about it until review.) If the goal is to communicate to the client that its rate of request issuance has hit an unacceptable level, the fact that we hit the limit on bytes in flight seems unimportant. I'm inclined to simply remove the TODOs and proceed with the behavior as it stands. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org