You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/10/23 17:07:04 UTC

Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39598/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-842
    https://issues.apache.org/jira/browse/LENS-842


Repository: lens


Description
-------

Currently rewritten query for JDBC driver is having backquote in alias name. This is not supported by all databases, changing this to double quote which is commonly used.


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 2d81ff2 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 77ab302 

Diff: https://reviews.apache.org/r/39598/diff/


Testing
-------

Added new unit test. mvn clean install is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [11.676s]
[INFO] Lens .............................................. SUCCESS [20.239s]
[INFO] Lens API .......................................... SUCCESS [40.179s]
[INFO] Lens API for server and extensions ................ SUCCESS [34.746s]
[INFO] Lens Cube ......................................... SUCCESS [7:55.199s]
[INFO] Lens DB storage ................................... SUCCESS [28.959s]
[INFO] Lens Query Library ................................ SUCCESS [26.757s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:38.749s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [58.672s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [28.183s]
[INFO] Lens Server ....................................... SUCCESS [26:57.251s]
[INFO] Lens client ....................................... SUCCESS [1:01.795s]
[INFO] Lens CLI .......................................... SUCCESS [1:30.578s]
[INFO] Lens Examples ..................................... SUCCESS [15.974s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [5.639s]
[INFO] Lens Distribution ................................. SUCCESS [22.021s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:17.458s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [16.127s]
[INFO] Lens Regression ................................... SUCCESS [28.530s]
[INFO] Lens UI ........................................... SUCCESS [33.597s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51:33.965s
[INFO] Finished at: Fri Oct 23 20:36:19 IST 2015
[INFO] Final Memory: 185M/1352M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty


Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39598/#review103913
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 23, 2015, 4:15 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39598/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-842
>     https://issues.apache.org/jira/browse/LENS-842
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Currently rewritten query for JDBC driver is having backquote in alias name. This is not supported by all databases, changing this to double quote which is commonly used.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 2d81ff2 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 77ab302 
> 
> Diff: https://reviews.apache.org/r/39598/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test. mvn clean install is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [11.676s]
> [INFO] Lens .............................................. SUCCESS [20.239s]
> [INFO] Lens API .......................................... SUCCESS [40.179s]
> [INFO] Lens API for server and extensions ................ SUCCESS [34.746s]
> [INFO] Lens Cube ......................................... SUCCESS [7:55.199s]
> [INFO] Lens DB storage ................................... SUCCESS [28.959s]
> [INFO] Lens Query Library ................................ SUCCESS [26.757s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:38.749s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [58.672s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [28.183s]
> [INFO] Lens Server ....................................... SUCCESS [26:57.251s]
> [INFO] Lens client ....................................... SUCCESS [1:01.795s]
> [INFO] Lens CLI .......................................... SUCCESS [1:30.578s]
> [INFO] Lens Examples ..................................... SUCCESS [15.974s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [5.639s]
> [INFO] Lens Distribution ................................. SUCCESS [22.021s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:17.458s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [16.127s]
> [INFO] Lens Regression ................................... SUCCESS [28.530s]
> [INFO] Lens UI ........................................... SUCCESS [33.597s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:33.965s
> [INFO] Finished at: Fri Oct 23 20:36:19 IST 2015
> [INFO] Final Memory: 185M/1352M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>


Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

Posted by Sushil Mohanty <su...@gmail.com>.

> On Oct. 25, 2015, 2:19 a.m., Srikanth Sundarrajan wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java, line 1169
> > <https://reviews.apache.org/r/39598/diff/2/?file=1105038#file1105038line1169>
> >
> >     Will this replace ` in any expression that we might be using in the select clause?

Yes. Commonly applicable for column alias.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39598/#review103920
-----------------------------------------------------------


On Oct. 23, 2015, 4:15 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39598/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-842
>     https://issues.apache.org/jira/browse/LENS-842
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Currently rewritten query for JDBC driver is having backquote in alias name. This is not supported by all databases, changing this to double quote which is commonly used.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 2d81ff2 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 77ab302 
> 
> Diff: https://reviews.apache.org/r/39598/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test. mvn clean install is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [11.676s]
> [INFO] Lens .............................................. SUCCESS [20.239s]
> [INFO] Lens API .......................................... SUCCESS [40.179s]
> [INFO] Lens API for server and extensions ................ SUCCESS [34.746s]
> [INFO] Lens Cube ......................................... SUCCESS [7:55.199s]
> [INFO] Lens DB storage ................................... SUCCESS [28.959s]
> [INFO] Lens Query Library ................................ SUCCESS [26.757s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:38.749s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [58.672s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [28.183s]
> [INFO] Lens Server ....................................... SUCCESS [26:57.251s]
> [INFO] Lens client ....................................... SUCCESS [1:01.795s]
> [INFO] Lens CLI .......................................... SUCCESS [1:30.578s]
> [INFO] Lens Examples ..................................... SUCCESS [15.974s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [5.639s]
> [INFO] Lens Distribution ................................. SUCCESS [22.021s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:17.458s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [16.127s]
> [INFO] Lens Regression ................................... SUCCESS [28.530s]
> [INFO] Lens UI ........................................... SUCCESS [33.597s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:33.965s
> [INFO] Finished at: Fri Oct 23 20:36:19 IST 2015
> [INFO] Final Memory: 185M/1352M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>


Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39598/#review103920
-----------------------------------------------------------



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java (line 1169)
<https://reviews.apache.org/r/39598/#comment162031>

    Will this replace ` in any expression that we might be using in the select clause?


- Srikanth Sundarrajan


On Oct. 23, 2015, 4:15 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39598/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-842
>     https://issues.apache.org/jira/browse/LENS-842
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Currently rewritten query for JDBC driver is having backquote in alias name. This is not supported by all databases, changing this to double quote which is commonly used.
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 2d81ff2 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 77ab302 
> 
> Diff: https://reviews.apache.org/r/39598/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test. mvn clean install is running fine.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [11.676s]
> [INFO] Lens .............................................. SUCCESS [20.239s]
> [INFO] Lens API .......................................... SUCCESS [40.179s]
> [INFO] Lens API for server and extensions ................ SUCCESS [34.746s]
> [INFO] Lens Cube ......................................... SUCCESS [7:55.199s]
> [INFO] Lens DB storage ................................... SUCCESS [28.959s]
> [INFO] Lens Query Library ................................ SUCCESS [26.757s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:38.749s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [58.672s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [28.183s]
> [INFO] Lens Server ....................................... SUCCESS [26:57.251s]
> [INFO] Lens client ....................................... SUCCESS [1:01.795s]
> [INFO] Lens CLI .......................................... SUCCESS [1:30.578s]
> [INFO] Lens Examples ..................................... SUCCESS [15.974s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [5.639s]
> [INFO] Lens Distribution ................................. SUCCESS [22.021s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:17.458s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [16.127s]
> [INFO] Lens Regression ................................... SUCCESS [28.530s]
> [INFO] Lens UI ........................................... SUCCESS [33.597s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51:33.965s
> [INFO] Finished at: Fri Oct 23 20:36:19 IST 2015
> [INFO] Final Memory: 185M/1352M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>


Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39598/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 4:15 p.m.)


Review request for lens.


Changes
-------

Renamed the method name.


Bugs: LENS-842
    https://issues.apache.org/jira/browse/LENS-842


Repository: lens


Description
-------

Currently rewritten query for JDBC driver is having backquote in alias name. This is not supported by all databases, changing this to double quote which is commonly used.


Diffs (updated)
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 2d81ff2 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 77ab302 

Diff: https://reviews.apache.org/r/39598/diff/


Testing
-------

Added new unit test. mvn clean install is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [11.676s]
[INFO] Lens .............................................. SUCCESS [20.239s]
[INFO] Lens API .......................................... SUCCESS [40.179s]
[INFO] Lens API for server and extensions ................ SUCCESS [34.746s]
[INFO] Lens Cube ......................................... SUCCESS [7:55.199s]
[INFO] Lens DB storage ................................... SUCCESS [28.959s]
[INFO] Lens Query Library ................................ SUCCESS [26.757s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:38.749s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [58.672s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [28.183s]
[INFO] Lens Server ....................................... SUCCESS [26:57.251s]
[INFO] Lens client ....................................... SUCCESS [1:01.795s]
[INFO] Lens CLI .......................................... SUCCESS [1:30.578s]
[INFO] Lens Examples ..................................... SUCCESS [15.974s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [5.639s]
[INFO] Lens Distribution ................................. SUCCESS [22.021s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:17.458s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [16.127s]
[INFO] Lens Regression ................................... SUCCESS [28.530s]
[INFO] Lens UI ........................................... SUCCESS [33.597s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51:33.965s
[INFO] Finished at: Fri Oct 23 20:36:19 IST 2015
[INFO] Final Memory: 185M/1352M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty