[jira] [Commented] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105692#comment-16105692 ] 

Jacques Le Roux commented on OFBIZ-9530:
----------------------------------------

Hi Kyra,

Your patch looks good to me. I agree that we can write only in English in log but I'd prefer to have a label for the sentence returned to users, I mean "No authentification result available to run service.", thanks :)

> Missing action in empty if-statement in accounting.PaymentGatewayServices
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-9530
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9530
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Priority: Minor
>         Attachments: OFBIZ-9530_PaymentGatewayServices_bugfix.patch
>
>
> In the method _processAuthResult_  line 1889 there is an empty if-statement for the case that authResult is null. It seems like somebody was planning to cover the case but forgot to add code.
> I would suggest to return a service error when the authResult is null since otherwise it cannot be determined if the payment is authorized or not.
> {code:java}
> boolean authResultOk = authResult.booleanValue();
>             
>             if (authResultOk) {
>                 orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
>             } else {
>                 orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)