You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 11:07:16 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue, #21467: [DistSQL] Add SQL parser test case for `AddShardingHintDatabaseValueStatement`

RaigorJiang opened a new issue, #21467:
URL: https://github.com/apache/shardingsphere/issues/21467

   ### Background
   
   `ADD SHARDING HINT DATABASE_VALUE xx = yy` is a syntax in [DistSQL RAL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/), when `ShardingSphereSQLParserEngine` receives this SQL text, it parses it as `AddShardingHintDatabaseValueStatement`. Now we need to add a test case for this parsing process to assert that the parsing is correct.
   
   
   ### Aim
   
   Add SQL parser test case for `AddShardingHintDatabaseValueStatement`.
   
   - Affected files:
   
     - SQLParserTestCases (**modify**)
   
     - test/parser/src/main/resources/case/ral/updatable.xml (**modify**)
   
     - test/parser/src/main/resources/sql/supported/ral/updatable.xml (**modify**)
   
     - test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/updatable/AddShardingHintDatabaseValueStatementTestCase.java (**create**)
   
     - test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/updatable/AddShardingHintDatabaseValueStatementAssert.java (**create**)
   
     - UpdatableRALStatementAssert (**modify**)
   
   
   - After all, execute `DistSQLParserParameterizedTest#assertDistSQL()` for validation
   
   ### Basic Qualifications
   
   - Java
   - Maven
   
   
   ### Example FYI
   
   - ImportDatabaseConfigurationStatement
   - ImportDatabaseConfigurationStatementTestCase
   - ImportDatabaseConfigurationStatementAssert
   - SQLParserTestCases
   - search for "import-database-config"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #21467: [DistSQL] Add SQL parser test case for `AddShardingHintDatabaseValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #21467: [DistSQL] Add SQL parser test case for `AddShardingHintDatabaseValueStatement`
URL: https://github.com/apache/shardingsphere/issues/21467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ankit-dub commented on issue #21467: [DistSQL] Add SQL parser test case for `AddShardingHintDatabaseValueStatement`

Posted by GitBox <gi...@apache.org>.
ankit-dub commented on issue #21467:
URL: https://github.com/apache/shardingsphere/issues/21467#issuecomment-1297242869

   I can take this task


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21467: [DistSQL] Add SQL parser test case for `AddShardingHintDatabaseValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21467:
URL: https://github.com/apache/shardingsphere/issues/21467#issuecomment-1297303104

   > @RaigorJiang I can take this task?
   
   Sure, thank you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org