You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/25 02:18:20 UTC
[GitHub] [incubator-nuttx] SuGlider opened a new pull request, #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
SuGlider opened a new pull request, #7693:
URL: https://github.com/apache/incubator-nuttx/pull/7693
## Summary
This PR adds a new configuration to Xtensa esp32-wrover-kit board that includes Lua Interpreter, MMCSD SPI support, User Leds and also Buttons.
It fixes an issue with conflicting User LEDs in ths board when a combination of MMCSD and Buttons is selected.
User LEDs use GPIO 0, 2 and 4.
MMCSD uses GPIO 2 as MISO
Buttons uses GPIO 0 as Input
Therefore, the fix tests if any of those are used and sets the remaining GPIOs for User LEDs, depending on the selected configuration.
## Impact
None.
## Testing
Using Configs: leds, buttons, mmcsd and lua. All os them worked correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032526811
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
The very first commit already includes all files... https://github.com/apache/nuttx/pull/7693/commits/1e771ae863ce8b832f595525368e931f5f534430
I can squash them all, but I think that I can't break a commit into 2 different commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1327506920
@SuGlider please squash and rebase your branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider closed pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider closed pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
URL: https://github.com/apache/nuttx/pull/7693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032316041
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
Review Comment:
```suggestion
#define BOARD_LED_RED BOARD_LED1 /* GPIO 0 */
#define BOARD_LED_GREEN BOARD_LED2 /* GPIO 2 */
#define BOARD_LED_BLUE BOARD_LED3 /* GPIO 4 */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else // MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 2
+#else
+#define BOARD_NLEDS 3
+#endif
+
+#endif
+
+
Review Comment:
```suggestion
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+ GPIO_LED3
+#else
+ GPIO_LED1, GPIO_LED3
+#endif
+
+#else // MMCSD
Review Comment:
```suggestion
#else /* MMCSD */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as
* USER LED
*/
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+ GPIO_LED3
+#else
+ GPIO_LED1, GPIO_LED3
+#endif
+
+#else // MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else // MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,39 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 // GPIO 0
+#define BOARD_LED_GREEN BOARD_LED2 // GPIO 2
+#define BOARD_LED_BLUE BOARD_LED3 // GPIO 4
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
+#ifdef CONFIG_MMCSD
+
+// GPIO 0 is used by BUTTONS, it can't be used as USER LED
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else // MMCSD
Review Comment:
```suggestion
#else /* MMCSD */
```
##########
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_userleds.c:
##########
@@ -42,7 +42,26 @@
static const uint32_t g_ledcfg[BOARD_NLEDS] =
{
+// GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as USER LED
Review Comment:
```suggestion
/* GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as
* USER LED
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider commented on pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1328034545
Thank you guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
tmedicci commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032502378
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,40 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 /* GPIO 0 */
+#define BOARD_LED_GREEN BOARD_LED2 /* GPIO 2 */
+#define BOARD_LED_BLUE BOARD_LED3 /* GPIO 4 */
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+/* GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as
+ * USER LED
+ */
+#ifdef CONFIG_MMCSD
+
+/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
+
+#else /* MMCSD */
+
+/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 2
+#else
+#define BOARD_NLEDS 3
+#endif
Review Comment:
```suggestion
#ifdef CONFIG_INPUT_BUTTONS
# define BOARD_NLEDS 2
#else
# define BOARD_NLEDS 3
#endif
```
##########
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##########
@@ -53,18 +53,40 @@
#define BOARD_LED1 0
#define BOARD_LED2 1
#define BOARD_LED3 2
-#define BOARD_NLEDS 3
-#define BOARD_LED_RED BOARD_LED1
-#define BOARD_LED_GREEN BOARD_LED2
-#define BOARD_LED_BLUE BOARD_LED3
+#define BOARD_LED_RED BOARD_LED1 /* GPIO 0 */
+#define BOARD_LED_GREEN BOARD_LED2 /* GPIO 2 */
+#define BOARD_LED_BLUE BOARD_LED3 /* GPIO 4 */
/* LED bits for use with autoleds */
#define BOARD_LED1_BIT (1 << BOARD_LED1)
#define BOARD_LED2_BIT (1 << BOARD_LED2)
#define BOARD_LED3_BIT (1 << BOARD_LED3)
+/* GPIO 2 is used by MMCSD driver as MISO, therefore, it can't be used as
+ * USER LED
+ */
+#ifdef CONFIG_MMCSD
+
+/* GPIO 0 is used by BUTTONS, it can't be used as USER LED */
+#ifdef CONFIG_INPUT_BUTTONS
+#define BOARD_NLEDS 1
+#else
+#define BOARD_NLEDS 2
+#endif
Review Comment:
```suggestion
#ifdef CONFIG_INPUT_BUTTONS
# define BOARD_NLEDS 1
#else
# define BOARD_NLEDS 2
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7693:
URL: https://github.com/apache/incubator-nuttx/pull/7693#issuecomment-1327042773
Please fix the style issue here:
https://github.com/apache/incubator-nuttx/actions/runs/3544821874/jobs/5953835220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032376791
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
Could you check if this works correctly with your project ?
```suggestion
#
# This file is autogenerated: PLEASE DO NOT EDIT IT.
#
# You can use "make menuconfig" to make any modifications to the installed .config file.
# You can then do "make savedefconfig" to generate a new defconfig file that includes your
# modifications.
#
# CONFIG_ARCH_LEDS is not set
# CONFIG_ESP32_SPI2_DMA is not set
# CONFIG_MMCSD_HAVE_CARDDETECT is not set
# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
# CONFIG_MMCSD_MMCSUPPORT is not set
# CONFIG_NSH_ARGCAT is not set
# CONFIG_NSH_CMDOPT_HEXDUMP is not set
# CONFIG_NSH_CMDPARMS is not set
# CONFIG_SPI_EXCHANGE is not set
CONFIG_ARCH="xtensa"
CONFIG_ARCH_BOARD="esp32-wrover-kit"
CONFIG_ARCH_BOARD_COMMON=y
CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
CONFIG_ARCH_BUTTONS=y
CONFIG_ARCH_CHIP="esp32"
CONFIG_ARCH_CHIP_ESP32=y
CONFIG_ARCH_CHIP_ESP32WROVER=y
CONFIG_ARCH_IRQBUTTONS=y
CONFIG_ARCH_STACKDUMP=y
CONFIG_ARCH_XTENSA=y
CONFIG_BOARD_LOOPSPERMSEC=16717
CONFIG_BUILTIN=y
CONFIG_DEBUG_ERROR=y
CONFIG_DEBUG_FEATURES=y
CONFIG_DEBUG_INFO=y
CONFIG_DEBUG_MEMCARD=y
CONFIG_DEBUG_MEMCARD_ERROR=y
CONFIG_DEBUG_MEMCARD_INFO=y
CONFIG_DEBUG_MEMCARD_WARN=y
CONFIG_DEBUG_WARN=y
CONFIG_ESP32_SPI2=y
CONFIG_ESP32_SPI2_CSPIN=13
CONFIG_ESP32_SPI2_MISOPIN=2
CONFIG_ESP32_SPI2_MOSIPIN=15
CONFIG_ESP32_UART0=y
CONFIG_EXAMPLES_BUTTONS=y
CONFIG_EXAMPLES_LEDS=y
CONFIG_EXAMPLES_LUA_MODULE=y
CONFIG_FAT_LCNAMES=y
CONFIG_FAT_LFN=y
CONFIG_FS_FAT=y
CONFIG_FS_PROCFS=y
CONFIG_HAVE_CXX=y
CONFIG_HAVE_CXXINITIALIZE=y
CONFIG_IDLETHREAD_STACKSIZE=3072
CONFIG_INIT_ENTRYPOINT="nsh_main"
CONFIG_INPUT=y
CONFIG_INPUT_BUTTONS=y
CONFIG_INPUT_BUTTONS_LOWER=y
CONFIG_INTELHEX_BINARY=y
CONFIG_INTERPRETERS_LUA=y
CONFIG_MMCSD=y
CONFIG_MMCSD_SPICLOCK=4000000
CONFIG_MM_REGIONS=3
CONFIG_NSH_ARCHINIT=y
CONFIG_NSH_BUILTIN_APPS=y
CONFIG_NSH_FILEIOSIZE=512
CONFIG_NSH_LINELEN=64
CONFIG_NSH_MMCSDSPIPORTNO=2
CONFIG_NSH_READLINE=y
CONFIG_PREALLOC_TIMERS=4
CONFIG_RAM_SIZE=114688
CONFIG_RAM_START=0x20000000
CONFIG_RR_INTERVAL=200
CONFIG_START_DAY=6
CONFIG_START_MONTH=12
CONFIG_START_YEAR=2011
CONFIG_SYSTEM_NSH=y
CONFIG_UART0_SERIAL_CONSOLE=y
CONFIG_USERLED=y
CONFIG_USERLED_LOWER=y
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032596444
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
I'll rebase it and commit it again in 2 pieces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032441040
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
Also, when squashing, I suggest making two different commits:
- boards/esp32-wrover-kit: Fix GPIO conflict
- boards/esp32-wrover-kit: Add Lua Interpreter defconfig
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
Also, when squashing, I suggest making two different commits:
- boards/esp32-wrover-kit: Fix GPIO conflicts
- boards/esp32-wrover-kit: Add Lua Interpreter defconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7693:
URL: https://github.com/apache/nuttx/pull/7693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032404565
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
The first config worked here (has run fine).
I have executed `./tools/refresh.sh esp32-wrover-kit:lua` and commited the changes to the PR.
The one that is now committed works fine with LUA / WroverKit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1327356061
Also, please fix the `esp32-wrover-kit/lua` defconfig.
You can use `./tools/refresh.sh esp32-wrover-kit:lua` to generate the correct options in the file. You can probably use all the default values suggested by the script, just make sure to double check if any modifications are needed for your project to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032411662
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
Nice! If the CI build passes without any errors, squash the commits and you are good to go 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider commented on a diff in pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032526811
##########
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##########
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_ARCH_LEDS is not set
+# CONFIG_ESP32_SPI2_DMA is not set
+# CONFIG_MMCSD_HAVE_CARDDETECT is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_MMCSUPPORT is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SPI_EXCHANGE is not set
+CONFIG_ARCH="xtensa"
+CONFIG_ARCH_BOARD="esp32-wrover-kit"
+CONFIG_ARCH_BOARD_COMMON=y
+CONFIG_ARCH_BOARD_ESP32_WROVERKIT=y
+CONFIG_ARCH_CHIP="esp32"
+CONFIG_ARCH_CHIP_ESP32=y
+CONFIG_ARCH_CHIP_ESP32WROVER=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARCH_XTENSA=y
+CONFIG_BOARD_LOOPSPERMSEC=16717
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_MEMCARD=y
+CONFIG_DEBUG_MEMCARD_ERROR=y
+CONFIG_DEBUG_MEMCARD_INFO=y
+CONFIG_DEBUG_MEMCARD_WARN=y
+CONFIG_DEBUG_WARN=y
+CONFIG_ESP32_SPI2=y
+CONFIG_ESP32_SPI2_CSPIN=13
+CONFIG_ESP32_SPI2_MISOPIN=2
+CONFIG_ESP32_SPI2_MOSIPIN=15
+CONFIG_ESP32_UART0=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_IDLETHREAD_STACKSIZE=3072
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INTELHEX_BINARY=y
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SPICLOCK=4000000
+CONFIG_MM_REGIONS=3
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_LINELEN=64
+CONFIG_NSH_MMCSDSPIPORTNO=2
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_RAM_SIZE=114688
+CONFIG_RAM_START=0x20000000
+CONFIG_RR_INTERVAL=200
+CONFIG_SCHED_WAITPID=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_NSH=y
+CONFIG_UART0_SERIAL_CONSOLE=y
+CONFIG_EXAMPLES_LEDS=y
+CONFIG_USERLED_LOWER=y
+CONFIG_USERLED=y
+CONFIG_INTERPRETERS_LUA=y
+CONFIG_EXAMPLES_LUA_MODULE=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ESP32_GPIO_IRQ=y
+CONFIG_EXAMPLES_BUTTONS=y
+CONFIG_INPUT=y
+CONFIG_INPUT_BUTTONS=y
+CONFIG_INPUT_BUTTONS_LOWER=y
Review Comment:
The very first commit already includes all files...
I can squash them all, but I think that I can't break a commit into 2 different commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] SuGlider commented on pull request #7693: Adds ESP32-WroverKit LUA config and fixes LEDs setup
Posted by GitBox <gi...@apache.org>.
SuGlider commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1327759808
> @SuGlider please squash and rebase your branch
Done. Let me know if this is all fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org