You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/16 09:19:53 UTC
[kudu-CR] BloomFileTestBase: refactor test fixture
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15446
to review the following change.
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
BloomFileTestBase: refactor test fixture
clang-tidy flags the gflag definitions in bloomfile-test-base.h for
potential ODR violations. To avoid that, let's move the bulk of the test
fixture into a new .cc file.
Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
---
M src/kudu/cfile/CMakeLists.txt
A src/kudu/cfile/bloomfile-test-base.cc
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
4 files changed, 174 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/15446/1
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
BloomFileTestBase: refactor test fixture
clang-tidy flags the gflag definitions in bloomfile-test-base.h for
potential ODR violations. To avoid that, let's move the bulk of the test
fixture into a new .cc file.
Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Reviewed-on: http://gerrit.cloudera.org:8080/15446
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/CMakeLists.txt
A src/kudu/cfile/bloomfile-test-base.cc
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
4 files changed, 173 insertions(+), 97 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:29:17 +0000
Gerrit-HasComments: No
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15446/1/src/kudu/cfile/bloomfile-test-base.h
File src/kudu/cfile/bloomfile-test-base.h:
http://gerrit.cloudera.org:8080/#/c/15446/1/src/kudu/cfile/bloomfile-test-base.h@20
PS1, Line 20: #include <stdint.h>
nit: could use <cstdint>
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 17:22:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15446/1/src/kudu/cfile/bloomfile-test-base.h
File src/kudu/cfile/bloomfile-test-base.h:
http://gerrit.cloudera.org:8080/#/c/15446/1/src/kudu/cfile/bloomfile-test-base.h@20
PS1, Line 20: #include <stdint.h>
> nit: could use <cstdint>
Done
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:22:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15446/1//COMMIT_MSG
Commit Message:
PS1:
Do we need to do this for other header-defined metrics? Looking at diskrowset-test-base.h and cfile-test-base.h.
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 19:43:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15446
to look at the new patch set (#2).
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
BloomFileTestBase: refactor test fixture
clang-tidy flags the gflag definitions in bloomfile-test-base.h for
potential ODR violations. To avoid that, let's move the bulk of the test
fixture into a new .cc file.
Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
---
M src/kudu/cfile/CMakeLists.txt
A src/kudu/cfile/bloomfile-test-base.cc
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
4 files changed, 173 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/15446/2
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:34:54 +0000
Gerrit-HasComments: No
[kudu-CR] BloomFileTestBase: refactor test fixture
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15446/1//COMMIT_MSG
Commit Message:
PS1:
> Do we need to do this for other header-defined metrics? Looking at diskrows
Yeah probably. I just happened to be here because I was working in mt-bloomfile-test and clang-tidy flagged it.
I'd rather not deal with the others right now though; the next person to touch those files can handle it. :)
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:24:52 +0000
Gerrit-HasComments: Yes