You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2013/04/20 12:40:16 UTC
[FalconJX] error: circular dependency
Alex,
Somewhere in your last commit(s) something broke. I'm now getting this
error when I run a cleanly build MXMLJSC with a cleanly build
FlexJSUI.swc and fresh compiler on the FlexJSTest_again example:
ERROR - Circular dependency detected: controllers.MyController ->
controllers.MyController
The tests do pass and the debug output works fine, so I'm guessing
it's the Closure Compiler that is reporting this error.
FYI: when I cut a branch from before your commits
(6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler,
all is well. And cutting a branch before Gordon's commits shows it's
not him, I'm afraid.
Any ideas?
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJX] error: circular dependency
Posted by Alex Harui <ah...@adobe.com>.
On 4/20/13 7:58 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
> I can't fix what I can't debug ;-)
Yup, I've been trying to add test cases that the customer hits but isn't in
FlexJSTest_again.
>
> Maybe spend a little time to abstract the pain points from that
> project into a "TestGoogProject" style test project, so we can all
> work on them? As an added bonus, by having (a) test(s) we'd prevent
> regressions like this one in future updates...
Yup, I thought the test cases you had set up would catch this, but I guess
not.
>
> EdB
>
>
>
> On Sat, Apr 20, 2013 at 4:43 PM, Alex Harui <ah...@adobe.com> wrote:
>> Yup.
>>
>>
>> On 4/20/13 7:29 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>>
>>> Yesterday all was well in dependency-land... was it your "customer's
>>> project" that caused you to tweak the algoritm?
>>>
>>> EdB
>>>
>>>
>>>
>>> On Sat, Apr 20, 2013 at 3:02 PM, Alex Harui <ah...@adobe.com> wrote:
>>>>
>>>>
>>>>
>>>> On 4/20/13 3:40 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>>>>
>>>>> Alex,
>>>>>
>>>>> Somewhere in your last commit(s) something broke. I'm now getting this
>>>>> error when I run a cleanly build MXMLJSC with a cleanly build
>>>>> FlexJSUI.swc and fresh compiler on the FlexJSTest_again example:
>>>>>
>>>>> ERROR - Circular dependency detected: controllers.MyController ->
>>>>> controllers.MyController
>>>>>
>>>>> The tests do pass and the debug output works fine, so I'm guessing
>>>>> it's the Closure Compiler that is reporting this error.
>>>>>
>>>>> FYI: when I cut a branch from before your commits
>>>>> (6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler,
>>>>> all is well. And cutting a branch before Gordon's commits shows it's
>>>>> not him, I'm afraid.
>>>>>
>>>>> Any ideas?
>>>>>
>>>> I'll look into it. This, IMO, is a major flaw in Closure. I can't tell
>>>> you
>>>> how many times I've tweaked this algorithm and how many hours we've wasted.
>>>>
>>>> --
>>>> Alex Harui
>>>> Flex SDK Team
>>>> Adobe Systems, Inc.
>>>> http://blogs.adobe.com/aharui
>>>>
>>>
>>>
>>
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>
>
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [FalconJX] error: circular dependency
Posted by Erik de Bruin <er...@ixsoftware.nl>.
I can't fix what I can't debug ;-)
Maybe spend a little time to abstract the pain points from that
project into a "TestGoogProject" style test project, so we can all
work on them? As an added bonus, by having (a) test(s) we'd prevent
regressions like this one in future updates...
EdB
On Sat, Apr 20, 2013 at 4:43 PM, Alex Harui <ah...@adobe.com> wrote:
> Yup.
>
>
> On 4/20/13 7:29 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>
>> Yesterday all was well in dependency-land... was it your "customer's
>> project" that caused you to tweak the algoritm?
>>
>> EdB
>>
>>
>>
>> On Sat, Apr 20, 2013 at 3:02 PM, Alex Harui <ah...@adobe.com> wrote:
>>>
>>>
>>>
>>> On 4/20/13 3:40 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>>>
>>>> Alex,
>>>>
>>>> Somewhere in your last commit(s) something broke. I'm now getting this
>>>> error when I run a cleanly build MXMLJSC with a cleanly build
>>>> FlexJSUI.swc and fresh compiler on the FlexJSTest_again example:
>>>>
>>>> ERROR - Circular dependency detected: controllers.MyController ->
>>>> controllers.MyController
>>>>
>>>> The tests do pass and the debug output works fine, so I'm guessing
>>>> it's the Closure Compiler that is reporting this error.
>>>>
>>>> FYI: when I cut a branch from before your commits
>>>> (6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler,
>>>> all is well. And cutting a branch before Gordon's commits shows it's
>>>> not him, I'm afraid.
>>>>
>>>> Any ideas?
>>>>
>>> I'll look into it. This, IMO, is a major flaw in Closure. I can't tell you
>>> how many times I've tweaked this algorithm and how many hours we've wasted.
>>>
>>> --
>>> Alex Harui
>>> Flex SDK Team
>>> Adobe Systems, Inc.
>>> http://blogs.adobe.com/aharui
>>>
>>
>>
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJX] error: circular dependency
Posted by Alex Harui <ah...@adobe.com>.
Yup.
On 4/20/13 7:29 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
> Yesterday all was well in dependency-land... was it your "customer's
> project" that caused you to tweak the algoritm?
>
> EdB
>
>
>
> On Sat, Apr 20, 2013 at 3:02 PM, Alex Harui <ah...@adobe.com> wrote:
>>
>>
>>
>> On 4/20/13 3:40 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>>
>>> Alex,
>>>
>>> Somewhere in your last commit(s) something broke. I'm now getting this
>>> error when I run a cleanly build MXMLJSC with a cleanly build
>>> FlexJSUI.swc and fresh compiler on the FlexJSTest_again example:
>>>
>>> ERROR - Circular dependency detected: controllers.MyController ->
>>> controllers.MyController
>>>
>>> The tests do pass and the debug output works fine, so I'm guessing
>>> it's the Closure Compiler that is reporting this error.
>>>
>>> FYI: when I cut a branch from before your commits
>>> (6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler,
>>> all is well. And cutting a branch before Gordon's commits shows it's
>>> not him, I'm afraid.
>>>
>>> Any ideas?
>>>
>> I'll look into it. This, IMO, is a major flaw in Closure. I can't tell you
>> how many times I've tweaked this algorithm and how many hours we've wasted.
>>
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>
>
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [FalconJX] error: circular dependency
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Yesterday all was well in dependency-land... was it your "customer's
project" that caused you to tweak the algoritm?
EdB
On Sat, Apr 20, 2013 at 3:02 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
>
> On 4/20/13 3:40 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>
>> Alex,
>>
>> Somewhere in your last commit(s) something broke. I'm now getting this
>> error when I run a cleanly build MXMLJSC with a cleanly build
>> FlexJSUI.swc and fresh compiler on the FlexJSTest_again example:
>>
>> ERROR - Circular dependency detected: controllers.MyController ->
>> controllers.MyController
>>
>> The tests do pass and the debug output works fine, so I'm guessing
>> it's the Closure Compiler that is reporting this error.
>>
>> FYI: when I cut a branch from before your commits
>> (6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler,
>> all is well. And cutting a branch before Gordon's commits shows it's
>> not him, I'm afraid.
>>
>> Any ideas?
>>
> I'll look into it. This, IMO, is a major flaw in Closure. I can't tell you
> how many times I've tweaked this algorithm and how many hours we've wasted.
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FalconJX] error: circular dependency
Posted by Alex Harui <ah...@adobe.com>.
On 4/20/13 3:40 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
> Alex,
>
> Somewhere in your last commit(s) something broke. I'm now getting this
> error when I run a cleanly build MXMLJSC with a cleanly build
> FlexJSUI.swc and fresh compiler on the FlexJSTest_again example:
>
> ERROR - Circular dependency detected: controllers.MyController ->
> controllers.MyController
>
> The tests do pass and the debug output works fine, so I'm guessing
> it's the Closure Compiler that is reporting this error.
>
> FYI: when I cut a branch from before your commits
> (6fd38b4ad9ed7d03844bd985f2902c762a737492) and rebuild the compiler,
> all is well. And cutting a branch before Gordon's commits shows it's
> not him, I'm afraid.
>
> Any ideas?
>
I'll look into it. This, IMO, is a major flaw in Closure. I can't tell you
how many times I've tweaked this algorithm and how many hours we've wasted.
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui