You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 17:37:02 UTC

[GitHub] [arrow] rafael-telles commented on pull request #12616: ARROW-14698: [Docs][FlightRPC] Add API docs for Flight SQL

rafael-telles commented on pull request #12616:
URL: https://github.com/apache/arrow/pull/12616#issuecomment-1075412871


   Hey @lidavidm !
   Commenting here as this may affect this docs: we just noticed that on `FlightSql.proto` there is some wrong documentation around `enum SqlInfo` values, saying they should retrieve `uint32` values where it should be `int64`. Like here:
   
   ```
     // Retrieves a uint32 value representing the maximum number of hex characters allowed in an inline binary literal.
     SQL_MAX_BINARY_LITERAL_LENGTH = 541;
   ```
   
   uint32 values are not returned by CommandGetSqlInfo, just int64 ones.
   
   Is it better to address this in another PR or in this one?
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org