[GitHub] [incubator-pinot] cecilynie commented on a change in pull request #5865: [TE] anomaly search - hide child anomaly unless queried with anomaly ids

[GitBox <gi...@apache.org>]

cecilynie commented on a change in pull request #5865:
URL: https://github.com/apache/incubator-pinot/pull/5865#discussion_r470779043



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearcher.java
##########
@@ -70,7 +70,11 @@ public AnomalySearcher() {
    * @return the result
    */
   public Map<String, Object> search(AnomalySearchFilter searchFilter, int limit, int offset) {
-    Predicate predicate = Predicate.EQ("child", false);
+    Predicate predicate = Predicate.NEQ("baseId", 0);

Review comment:
       Hi Jihao, is there a way for us to test the fix before waiting for the next deployment? This is a bit critical which is impacting all entity monitoring. Let's make sure it works when we deploy.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org