[GitHub] [guacamole-client] necouchman commented on a change in pull request #552: GUACAMOLE-1135: Return StoreUrls in URI format

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #552:
URL: https://github.com/apache/guacamole-client/pull/552#discussion_r460460367



##########
File path: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java
##########
@@ -95,7 +95,7 @@ public MySQLAuthenticationProviderModule(MySQLEnvironment environment)
         File trustStore = environment.getMySQLSSLTrustStore();
         if (trustStore != null)
             driverProperties.setProperty("trustCertificateKeyStoreUrl",
-                    trustStore.getAbsolutePath());
+                    String.valueOf(trustStore.toURI()));

Review comment:
       Instead of `String.valueOf()` it seems like it would be better to use the `URI` class's `toString()` method, here.  It's possible that's already what `String.valueOf()` does under the hood, but seems like a more direct reference to it would be better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org