You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/08 11:17:48 UTC
[GitHub] [arrow] rtpsw commented on a diff in pull request #14043: ARROW-17613: [C++] Add function execution API for a preconfigured kernel
rtpsw commented on code in PR #14043:
URL: https://github.com/apache/arrow/pull/14043#discussion_r965828630
##########
cpp/src/arrow/compute/function.h:
##########
@@ -225,6 +233,15 @@ class ARROW_EXPORT Function {
/// required by the kernel.
virtual Result<const Kernel*> DispatchBest(std::vector<TypeHolder>* values) const;
+ /// \brief Get a function executor with a best-matching kernel
+ virtual Result<std::shared_ptr<FunctionExecutor>> BestExecutor(
+ const std::vector<Datum>& args, const FunctionOptions* options,
+ ExecContext* ctx) const;
Review Comment:
Makes sense and I'll look into this. So far I just refractored in a simple way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org