You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/17 03:34:20 UTC

[GitHub] [skywalking] linliaoy opened a new issue #5504: 8.1.0 Segment sampling is bad

linliaoy opened a new issue #5504:
URL: https://github.com/apache/skywalking/issues/5504


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   skywalking 8.1.0
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, component version.
   package org.apache.skywalking.oap.server.analyzer.provider.trace.parser.listener;
   segmentId.hashCode() It's going to be negative。SW_TRACE_SAMPLE_RATE is configured to be positive
   
   example：
   segmentid ：40ae9aaa370449bd80b61452fcf04154.125.16003124206517460
   hashCode：-103557884
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5504: 8.1.0 Segment sampling is bad

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5504:
URL: https://github.com/apache/skywalking/issues/5504#issuecomment-693791804


   Thanks for your report, this is a bug for backend sampling.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5504: 8.1.0 Segment sampling is bad

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5504:
URL: https://github.com/apache/skywalking/issues/5504#issuecomment-693792045


   Could you try to send a pull request to fix this? Adding `Math#abs` should be an easy fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5504: 8.1.0 Segment sampling bug

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5504:
URL: https://github.com/apache/skywalking/issues/5504


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] linliaoy commented on issue #5504: 8.1.0 Segment sampling bug

Posted by GitBox <gi...@apache.org>.
linliaoy commented on issue #5504:
URL: https://github.com/apache/skywalking/issues/5504#issuecomment-693949262


   #5506 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] N-Harsha commented on issue #5504: 8.1.0 Segment sampling bug

Posted by GitBox <gi...@apache.org>.
N-Harsha commented on issue #5504:
URL: https://github.com/apache/skywalking/issues/5504#issuecomment-694064137


   i am a newbie and want work on this issue so please could you point me in the right direction
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org