You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/11 06:32:49 UTC

[GitHub] [helix] kaisun2000 commented on issue #924: Fix ZkHelixPropertyStore loses Zookeeper notification issue

kaisun2000 commented on issue #924: Fix ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#issuecomment-612344941
 
 
   This PR is ready to be merged, approved by @jiajunwang 
   
   Final message:
       fix ZkHelixPropertyStore loses Zookeeper notification issue
       
       ZkHelixPropertyStore loses ZK notification after session expires.
       THe issue was caused by a bug in Share ZkClient code path. More
       specifically, Share ZkClient would not call fireAllEvent when ZK
       session expires. Thus, ZkHelixPropertyStore would not install
       watches for corresponding ZkPath. Thus, lose Zookeeper
       nofiticaition when changes happens.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org