[GitHub] [rocketmq] leikang123 opened a new pull request #3343: Add comments to the two enumeration codes store/config/BrokerRole.java and FlushDiskType.java

[GitBox <gi...@apache.org>]

leikang123 opened a new pull request #3343:
URL: https://github.com/apache/rocketmq/pull/3343


   ``…java and store/src/main/java/org/apache/rocketmq/store/config/FlushDiskType.java two enumeration codes Supplementary notes
   
   package org.apache.rocketmq.store.config;
   
   /**
    * define BrokerRole enum class
    */
   public enum BrokerRole {
       /**
        * When the slave and master messages are completed asynchronously,
        * there is no need to send a successful status
        */
       ASYNC_MASTER,
       /**
        * When the slave and master messages are synchronized,
        * they will return to the status of successful sending
        */
       SYNC_MASTER,
       /**
        * Indicates the slave, used to read the message
        */
       SLAVE;
   }
   ``package org.apache.rocketmq.store.config;
   
   /**
    * Define the disk brush enumeration class
    */
   public enum FlushDiskType {
       /**
        * Indicates synchronous brushing
        */
       SYNC_FLUSH,
       /**
        * Indicates asynchronous brushing
        */
       ASYNC_FLUSH
   }
   **I will continue to submit the code comments under other packages later!**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed pull request #3343: Add comments to the two enumeration codes store/config/BrokerRole.java and FlushDiskType.java

[GitBox <gi...@apache.org>]

RongtongJin closed pull request #3343:
URL: https://github.com/apache/rocketmq/pull/3343


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] leikang123 commented on pull request #3343: Add comments to the two enumeration codes store/config/BrokerRole.java and FlushDiskType.java

[GitBox <gi...@apache.org>]

leikang123 commented on pull request #3343:
URL: https://github.com/apache/rocketmq/pull/3343#issuecomment-917406347


   Oh, I see. Which layers of code are more complex, or indicate what I can contribute. Thank you!
   
   
   
   
   
   
   
   发自我的iPhone
   
   
   ------------------ Original ------------------
   From: rongtong ***@***.***>
   Date: Sat,Sep 11,2021 9:11 PM
   To: apache/rocketmq ***@***.***>
   Cc: leikang123 ***@***.***>, Mention ***@***.***>
   Subject: Re: [apache/rocketmq] Add comments to the two enumeration codes store/config/BrokerRole.java and FlushDiskType.java (#3343)
   
   
   
   
   
    
   @RongtongJin commented on this pull request.
    
   Hi,  @leikang123  Welcome to contribute code to the rocketmq community. IMO, a lot of comments are unnecessary and redundant for these three files in this pull request,  FlushDiskType and BrokeRole don't need extra attention, comments should be a concise explanation of complex code.  Hope you can submit a more meaningful pull request.
    
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org