[GitHub] [superset] michael-s-molina commented on pull request #16940: chore(Dashboard): Highlight errored filters on the left pane of the Native Filters form plus several enhancements

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #16940:
URL: https://github.com/apache/superset/pull/16940#issuecomment-933639782


   Thanks for the feature @geido. Some points:
   - When creating a new filter, the name is "New Filter" and not "[untitled]". I liked your idea, so it should start as "[untitled]"
   - If you generate an error in a saved filter, like deleting its name, and cancel, the error shows when reopening
   - The error icon position will conflict with the drag icon that is being implemented [here](https://github.com/apache/superset/pull/16154). Maybe position it on the right side?
   - Should we make the error icon the same as the trash icon?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org