You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by Sebastian <no...@gmx.net> on 2010/12/01 21:12:20 UTC

wicket-shiro LoginPanel always redirects to a stateful homepage instance

Is there any good reason why in 
org.wicketstuff.shiro.component.LoginPanel.onSignInSucceeded the 
redirect to the homepage is done using

setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()))

instead of

setResponsePage(getApplication().getHomePage())

The former eventually results in the page being flagged automatically as 
stateful at one point of the request cylce.

I changed it in my local copy branch, the login and redirect still 
works, and the StatelesChecker does not raise an exception after login 
anymore. So I'd like to change that in the wicketstuff SVN too.

any thoughts?


Regards,

Seb

Re: wicket-shiro LoginPanel always redirects to a stateful homepage instance

Posted by Sebastian <no...@gmx.net>.

Ok, I applied the change to 1.4.15-SNAPSHOT now.

Regards,
Seb

On 02.12.2010 10:03, Martin Grigorov wrote:
> In trunk (1.5-SNAPSHOT) it is setResponsePage(getApplication().getHomePage())
> already
>
> I see you committed your improvement with the StatelessForm in both
> branches. Thanks !
>
> On Wed, Dec 1, 2010 at 9:12 PM, Sebastian<no...@gmx.net>  wrote:
>
>> Is there any good reason why in
>> org.wicketstuff.shiro.component.LoginPanel.onSignInSucceeded the redirect to
>> the homepage is done using
>>
>>
>> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()))
>>
>> instead of
>>
>> setResponsePage(getApplication().getHomePage())
>>
>> The former eventually results in the page being flagged automatically as
>> stateful at one point of the request cylce.
>>
>> I changed it in my local copy branch, the login and redirect still works,
>> and the StatelesChecker does not raise an exception after login anymore. So
>> I'd like to change that in the wicketstuff SVN too.
>>
>> any thoughts?
>>
>>
>> Regards,
>>
>> Seb

Re: wicket-shiro LoginPanel always redirects to a stateful homepage instance

Posted by Martin Grigorov <mg...@apache.org>.

In trunk (1.5-SNAPSHOT) it is setResponsePage(getApplication().getHomePage())
already

I see you committed your improvement with the StatelessForm in both
branches. Thanks !

On Wed, Dec 1, 2010 at 9:12 PM, Sebastian <no...@gmx.net> wrote:

> Is there any good reason why in
> org.wicketstuff.shiro.component.LoginPanel.onSignInSucceeded the redirect to
> the homepage is done using
>
>
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()))
>
> instead of
>
> setResponsePage(getApplication().getHomePage())
>
> The former eventually results in the page being flagged automatically as
> stateful at one point of the request cylce.
>
> I changed it in my local copy branch, the login and redirect still works,
> and the StatelesChecker does not raise an exception after login anymore. So
> I'd like to change that in the wicketstuff SVN too.
>
> any thoughts?
>
>
> Regards,
>
> Seb
>
>
>