You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/02/21 14:19:16 UTC

Review Request 65733: Windows: Fixed flaky Docker command health check test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
DockerHealthStatusChange` test was flaky on Windows, because
the docker executor manually reaps the container exit code in
case that `docker run` fails to get the exit code. This logic
doesn't work on Windows, since the process might not be visible to
the container host machine, causing `TASK_FAILED` to get sent. By
removing the reaping logic on Windows, the test is much more reliable.


Diffs
-----

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65733/diff/1/


Testing
-------


Thanks,

Akash Gupta

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Akash Gupta <ak...@hotmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review197853
-----------------------------------------------------------



In case you want more details, the bug was introduced in https://github.com/apache/mesos/commit/a7714536fad1140fd0c07c47e32b40e9ed00a3c3#diff-9ed238cb3a33c53838909dd0ad5ae589 since that workaround only works on Linux.

- Akash Gupta


On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 2:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Gilbert Song <so...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review198575
-----------------------------------------------------------



Should we update the *bug*# to MESOS-8488?

- Gilbert Song


On Feb. 21, 2018, 6:19 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 6:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review197901
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 65615.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65615`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733

Relevant logs:

- [apply-review-65615-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733/logs/apply-review-65615-stdout.log):

```
error: patch failed: src/tests/mesos.hpp:2170
error: src/tests/mesos.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 21, 2018, 6:19 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 6:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review197900
-----------------------------------------------------------



Bad patch!

Reviews applied: [65733, 65727, 64387, 65615, 65127, 65419, 65396, 65395, 65394, 65393]

Failed command: python support/apply-reviews.py -n -r 65615

Error:
2018-02-21 15:56:34 URL:https://reviews.apache.org/r/65615/diff/raw/ [10438/10438] -> "65615.patch" [1]
error: patch failed: src/tests/mesos.hpp:2170
error: src/tests/mesos.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/21713/console

- Mesos Reviewbot


On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 2:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review197911
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 65615.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65615`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733

Relevant logs:

- [apply-review-65615-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733/logs/apply-review-65615-stdout.log):

```
error: patch failed: src/tests/mesos.hpp:2170
error: src/tests/mesos.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 2:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review198000
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Feb. 21, 2018, 6:19 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 6:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/#review197902
-----------------------------------------------------------



FAIL: Failed to get dependent review IDs for the current patch.

Failed command: `python.exe C:\Jenkins\workspace\mesos-reviewbot-testing\Mesos\utils\get-review-ids.py -r 65733 -o C:\Users\mesos\AppData\Local\Temp\mesos_dependent_review_ids`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733

Relevant logs:

- [get-review-ids-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733/logs/get-review-ids-stdout.log):

```
Dependent review: https://reviews.apache.org/api/review-requests/65727/ 
Dependent review: https://reviews.apache.org/api/review-requests/64387/ 
Dependent review: https://reviews.apache.org/api/review-requests/65615/ 
Dependent review: https://reviews.apache.org/api/review-requests/65127/ 
Dependent review: https://reviews.apache.org/api/review-requests/65419/ 
Dependent review: https://reviews.apache.org/api/review-requests/65396/ 
Dependent review: https://reviews.apache.org/api/review-requests/65395/ 
Dependent review: https://reviews.apache.org/api/review-requests/65394/ 
Dependent review: https://reviews.apache.org/api/review-requests/65393/ 
```

- [get-review-ids-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65733/logs/get-review-ids-stderr.log):

```
Traceback (most recent call last):
  File "C:\Jenkins\workspace\mesos-reviewbot-testing\Mesos\utils\get-review-ids.py", line 51, in <module>
    main()
  File "C:\Jenkins\workspace\mesos-reviewbot-testing\Mesos\utils\get-review-ids.py", line 46, in main
    for r_id in review_ids:
TypeError: 'NoneType' object is not iterable
```

- Mesos Reviewbot Windows


On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65733/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 2:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
> DockerHealthStatusChange` test was flaky on Windows, because
> the docker executor manually reaps the container exit code in
> case that `docker run` fails to get the exit code. This logic
> doesn't work on Windows, since the process might not be visible to
> the container host machine, causing `TASK_FAILED` to get sent. By
> removing the reaping logic on Windows, the test is much more reliable.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>