[GitHub] [lucene-solr] mocobeta edited a comment on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

[GitBox <gi...@apache.org>]

mocobeta edited a comment on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530614095
 
 
   As far as LUCENE-8816 ("Decouple Kuromoji's morphological analyser and its dictionary") and related or sub issues, I do not intend to backport them to the 8x branch. I feel like that it's a too big change to be included within minor releases, and exhaustive functional/performance tests will be needed for it.
   Sorry for not providing clear whole picture so far, I could not take much time for this but it's of course always in my mind.
   
   I think it's ok to merge minor refactors for Kuromoji to 8x branch, if they are just code clean-ups or good for 8x users. I don't have any opinions about shipping experimental changes with 8.x (I have no idea about what "experimental" means on this project).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org