You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/20 23:51:40 UTC
[GitHub] [pinot] xiangfu0 opened a new issue #7609: Separate errors for function call error message
xiangfu0 opened a new issue #7609:
URL: https://github.com/apache/pinot/issues/7609
When users have a typo in function name or have mismatched function signature, Pinot gives `Unsupported function` error.
```
Unsupported function: distinctcountll with 1 parameters\n\tat org.apache.pinot.core.operator.transform.function.TransformFunctionFactory.get
```
It will be helpful if the error message can specify if the function name is unknown or the function signature doesn't match(maybe better to show the correct signatures).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kriti-sc edited a comment on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
kriti-sc edited a comment on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-950168415
@xiangfu0
I assume you mean having the error message convey something like `Did you mean 'distinct' instead of 'distinctcountll'?`
Would it make sense to point to the docs instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-958682583
> @xiangfu0 I assume you mean having the error message convey something like `Did you mean 'distinct' instead of 'distinctcountll'?`
>
> Would it make sense to point to the docs instead?
Current error message(`Unsupported function: distinctcountll with 1 parameters`) mentioned the error could come from two parts:
1. Function name is wrong, e.g. user may write cout instead of count
2. Function name is correct but the arguments is wrong, e.g. sum(a) is supported, but not sum(a,b)
We want this error message to be more specific on which error it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kriti-sc commented on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
kriti-sc commented on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-948355741
Picking this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-958682583
> @xiangfu0 I assume you mean having the error message convey something like `Did you mean 'distinct' instead of 'distinctcountll'?`
>
> Would it make sense to point to the docs instead?
Current error message(`Unsupported function: distinctcountll with 1 parameters`) mentioned the error could come from two parts:
1. Function name is wrong, e.g. user may write cout instead of count
2. Function name is correct but the arguments is wrong, e.g. sum(a) is supported, but not sum(a,b)
We want this error message to be more specific on which error it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kriti-sc commented on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
kriti-sc commented on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-950168415
@xiangfu0
I assume you mean having the error message convey something like `Did you mean distinct instead of distinctcountll?`
Would it make sense to point to the docs instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 closed issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
xiangfu0 closed issue #7609:
URL: https://github.com/apache/pinot/issues/7609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-958682583
> @xiangfu0 I assume you mean having the error message convey something like `Did you mean 'distinct' instead of 'distinctcountll'?`
>
> Would it make sense to point to the docs instead?
Current error message(`Unsupported function: distinctcountll with 1 parameters`) mentioned the error could come from two parts:
1. Function name is wrong, e.g. user may write cout instead of count
2. Function name is correct but the arguments is wrong, e.g. sum(a) is supported, but not sum(a,b)
We want this error message to be more specific on which error it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7609: Separate errors for function call error message
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7609:
URL: https://github.com/apache/pinot/issues/7609#issuecomment-958682583
> @xiangfu0 I assume you mean having the error message convey something like `Did you mean 'distinct' instead of 'distinctcountll'?`
>
> Would it make sense to point to the docs instead?
Current error message(`Unsupported function: distinctcountll with 1 parameters`) mentioned the error could come from two parts:
1. Function name is wrong, e.g. user may write cout instead of count
2. Function name is correct but the arguments is wrong, e.g. sum(a) is supported, but not sum(a,b)
We want this error message to be more specific on which error it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org