You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/06 02:48:50 UTC

[GitHub] [spark] sarutak commented on a change in pull request #29356: [SPARK-32538][TEST] Use local time zone for the timestamp logged in unit-tests.log

sarutak commented on a change in pull request #29356:
URL: https://github.com/apache/spark/pull/29356#discussion_r466113982



##########
File path: core/src/test/scala/org/apache/spark/SparkFunSuite.scala
##########
@@ -65,6 +65,12 @@ abstract class SparkFunSuite
   with Logging {
 // scalastyle:on
 
+  // Initialize the logger forcibly to let the logger log timestamp
+  // based on the local time zone depending on environments.
+  // The default time zone will be set to America/Los_Angeles later
+  // so this initialization is necessary here.
+  log

Review comment:
       Seems so. `DateFormat` classes used in log4j uses `Calendar`, which is instantiated in the constructor with the default time zone at the time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org