[GitHub] [shardingsphere] azexcy commented on a diff in pull request #24924: Use JsonFormat print records of CDC response

["azexcy (via GitHub)" <gi...@apache.org>]

azexcy commented on code in PR #24924:
URL: https://github.com/apache/shardingsphere/pull/24924#discussion_r1154298237


##########
kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/impl/MigrationJobAPI.java:
##########
@@ -423,8 +423,8 @@ private void cleanTempTableOnRollback(final String jobId) throws SQLException {
     public void commit(final String jobId) {
         log.info("Commit job {}", jobId);
         final long startTimeMillis = System.currentTimeMillis();
-        dropCheckJobs(jobId);
         stop(jobId);
+        dropCheckJobs(jobId);

Review Comment:
   Fix the error log from ci
   
   ```
   [INFO ] 2023-03-31 09:49:18.688 [docker-java-stream-786712462] :ShardingSphere-Proxy - STDOUT: [WARN ] 2023-03-31 09:49:18.163 [Connection-3-ThreadExecutor] o.a.s.d.p.s.m.a.impl.MigrationJobAPI - stop related check job failed, check job id: j0202p0000j0102p0000af4a124b05e9bb3c7ce635279b74d91d1, error: Can not find pipeline job `j0202p0000j0102p0000af4a124b05e9bb3c7ce635279b74d91d1`.
   [INFO ] 2023-03-31 09:49:18.688 [docker-java-stream-786712462] :ShardingSphere-Proxy - STDOUT: [INFO ] 2023-03-31 09:49:18.186 [Pipeline-EventListener-1] o.a.s.d.p.c.m.n.e.h.i.ConfigMetaDataChangedEventHandler - UPDATED job configuration: /pipeline/jobs/j0102p0000af4a124b05e9bb3c7ce635279b74d91d/config, disabled=true
   [INFO ] 2023-03-31 09:49:18.688 [docker-java-stream-786712462] :ShardingSphere-Proxy - STDOUT: [INFO ] 2023-03-31 09:49:18.186 [Pipeline-EventListener-1] o.a.s.d.p.c.job.AbstractPipelineJob - stop tasks runner, jobId=j0102p0000af4a124b05e9bb3c7ce635279b74d91d
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org