You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/04/14 10:15:55 UTC

[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #197: Render descriptions using markdown

ahgittin commented on a change in pull request #197:
URL: https://github.com/apache/brooklyn-ui/pull/197#discussion_r613120645



##########
File path: ui-modules/catalog/app/views/catalog/catalog.template.html
##########
@@ -69,7 +69,7 @@
         </div>
 
         <div class="col-md-12">
-            <ul class="list-group list-group-bundles" ng-show="state.view === 'bundles'">
+            <ul class="list-group list-group-bundles" ng-if="state.view === 'bundles'">

Review comment:
       If you have a lot of bundles with a lot of types, we _don't_ want them all to render as that is expensive on first load.  I think taking the hit when expanded/collapsed is better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org