[GitHub] dongjoon-hyun edited a comment on issue #23350: [SPARK-26366][SQL][BACKPORT-2.3] ReplaceExceptWithFilter should consider NULL as False

[GitBox <gi...@apache.org>]

dongjoon-hyun edited a comment on issue #23350: [SPARK-26366][SQL][BACKPORT-2.3] ReplaceExceptWithFilter should consider NULL as False
URL: https://github.com/apache/spark/pull/23350#issuecomment-449542843
 
 
   Sorry, guys. I'll revert this. All tests on `branch-2.3` fail. It's not about flakiness.
   
   The newly added UT itself fails. @mgaido91 , could you revise the UT and make another PR once  more?
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.3-test-maven-hadoop-2.6/562/
   ```
   == FAIL: Plans do not match ===
    Aggregate [a#0, b#0], [a#0, b#0]                             Aggregate [a#0, b#0], [a#0, b#0]
   !+- Filter NOT coalesce((a#0 IN (1,2) || b#0 IN ()), false)   +- Filter NOT coalesce((a#0 IN (1,2) || if (isnotnull(b#0)) false else null), false)
       +- LocalRelation <empty>, [a#0, b#0]                         +- LocalRelation <empty>, [a#0, b#0]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org