You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/18 15:42:15 UTC

[GitHub] [incubator-superset] kkucharc opened a new pull request #10958: fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py

kkucharc opened a new pull request #10958:
URL: https://github.com/apache/incubator-superset/pull/10958


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Lint rule `too-many-locals` isn't raising issues anymore.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kkucharc commented on pull request #10958: fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py

Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10958:
URL: https://github.com/apache/incubator-superset/pull/10958#issuecomment-695968246


   Thank you for the review @mistercrunch.
   cc: @willbarrett I believe it's ready for merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar merged pull request #10958: fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10958:
URL: https://github.com/apache/incubator-superset/pull/10958


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10958: fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10958:
URL: https://github.com/apache/incubator-superset/pull/10958#issuecomment-694947169


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=h1) Report
   > Merging [#10958](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e375ed4678d7d6f82f11151f0f5023e664b5b62f?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10958/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10958      +/-   ##
   ==========================================
   - Coverage   61.57%   61.45%   -0.13%     
   ==========================================
     Files         815      815              
     Lines       38335    38341       +6     
     Branches     3601     3601              
   ==========================================
   - Hits        23605    23561      -44     
   - Misses      14544    14594      +50     
     Partials      186      186              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `61.75% <ø> (ø)` | |
   | #python | `61.27% <ø> (-0.20%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `89.43% <ø> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.27% <0.00%> (-1.98%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=footer). Last update [e375ed4...fe4ae60](https://codecov.io/gh/apache/incubator-superset/pull/10958?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar merged pull request #10958: fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10958:
URL: https://github.com/apache/incubator-superset/pull/10958


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kkucharc commented on pull request #10958: fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py

Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10958:
URL: https://github.com/apache/incubator-superset/pull/10958#issuecomment-695968246


   Thank you for the review @mistercrunch.
   cc: @willbarrett I believe it's ready for merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org