You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/28 19:06:13 UTC

[GitHub] [flink] zentol opened a new pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

zentol opened a new pull request #14511:
URL: https://github.com/apache/flink/pull/14511


   It was not possible to just run 'mvn spotless:check', but instead one needed to use the fully qualified name of the plugin, i.e., 'mvn com.diffplug.spotless:spotless-maven-plugin:check'.
   
   This is due to 'force-shading'; this module is declared as a child of the flink-parent pom (i.e., the root pom of the project), but is not actually declaring that very module as it's parent.
   This seems to throw of maven, which fails to retrieve the plugin information from the parent.
   
   Note that this is just a band-aid; a proper fix would declare flink-parent as the parent of force-shading, but this is the easier fix.
   We could also think of finally migrating to flink-shaded-force-shading, or before that, verify whether the original issue that causes us to introduce force-shading actually still exists.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14511:
URL: https://github.com/apache/flink/pull/14511#issuecomment-751831985

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d (Fri May 28 06:58:00 UTC 2021)

**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

zentol merged pull request #14511:
URL: https://github.com/apache/flink/pull/14511


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14511:
URL: https://github.com/apache/flink/pull/14511#issuecomment-751833305


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11407",
       "triggerID" : "c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11407) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14511:
URL: https://github.com/apache/flink/pull/14511#issuecomment-751833305


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11407",
       "triggerID" : "c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11407) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14511:
URL: https://github.com/apache/flink/pull/14511#issuecomment-751831985

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d (Mon Dec 28 19:08:40 UTC 2020)

**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on a change in pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

pnowojski commented on a change in pull request #14511:
URL: https://github.com/apache/flink/pull/14511#discussion_r549611719



##########
File path: tools/force-shading/pom.xml
##########
@@ -43,6 +43,21 @@ under the License.
 
 	<packaging>jar</packaging>
 
+	<build>
+		<pluginManagement>
+			<plugins>
+				<plugin>
+					<!-- This only exists to allow shorthand invocations on the command-line
+						i.e., 'mvn spotless:check'
+						This is necessary because this module does not declare the flink-parent pom as its parent -->

Review comment:
       Maybe create a ticket for the proper fix and reference it here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14511: [FLINK-20792][build] Allow shorthand calls to spotless

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14511:
URL: https://github.com/apache/flink/pull/14511#issuecomment-751833305


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c041a8acda3fb68859a8ecc8a2901dfcb3ce7c2d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org