You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/05/10 15:00:14 UTC
Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
Diff: https://reviews.apache.org/r/59146/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On May 10, 2017, 5:05 p.m., Alexander Rukletsov wrote:
> > What about V1 protos?
Dang! Sorry, will add that ASAP, always forget about them.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/#review174481
-----------------------------------------------------------
On May 10, 2017, 5 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59146/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 5 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
>
>
> Diff: https://reviews.apache.org/r/59146/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/#review174481
-----------------------------------------------------------
What about V1 protos?
- Alexander Rukletsov
On May 10, 2017, 3 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59146/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 3 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
>
>
> Diff: https://reviews.apache.org/r/59146/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/#review174646
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On May 10, 2017, 5:09 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59146/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 5:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
> include/mesos/v1/resource_provider/resource_provider.proto 97a85ce34eeecf86d14c097712867cd24624a6ec
>
>
> Diff: https://reviews.apache.org/r/59146/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/#review174567
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59146]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 10, 2017, 3:09 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59146/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 3:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
> include/mesos/v1/resource_provider/resource_provider.proto 97a85ce34eeecf86d14c097712867cd24624a6ec
>
>
> Diff: https://reviews.apache.org/r/59146/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/#review182645
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On May 10, 2017, 3:09 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59146/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 3:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
> include/mesos/v1/resource_provider/resource_provider.proto 97a85ce34eeecf86d14c097712867cd24624a6ec
>
>
> Diff: https://reviews.apache.org/r/59146/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State
enumeration.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59146/
-----------------------------------------------------------
(Updated May 10, 2017, 5:09 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
Changes
-------
Added v1 protobuf.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 11d01df114eafb729514dab64596c5f1ecf09f26
include/mesos/v1/resource_provider/resource_provider.proto 97a85ce34eeecf86d14c097712867cd24624a6ec
Diff: https://reviews.apache.org/r/59146/diff/2/
Changes: https://reviews.apache.org/r/59146/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht