You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/29 06:15:40 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2729: [Enhancement] Method check a map with containsKey(), before using get() [UnSubscribeProcessor]
Alonexc opened a new issue, #2729:
URL: https://github.com/apache/incubator-eventmesh/issues/2729
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/UnSubscribeProcessor.java line 166
analysis and explanation:
This method checks for the presence of a key in a map using containsKey(), before attempting to fetch the value of the key using get(). This equates to doing two map lookups in a row.
### Describe the solution you'd like
It is much simpler to just fetch the value with get, and checking for non null instead.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #2729: [Enhancement] Method check a map with containsKey(), before using get() [UnSubscribeProcessor]
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #2729: [Enhancement] Method check a map with containsKey(), before using get() [UnSubscribeProcessor]
URL: https://github.com/apache/incubator-eventmesh/issues/2729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx commented on issue #2729: [Enhancement] Method check a map with containsKey(), before using get() [UnSubscribeProcessor]
Posted by GitBox <gi...@apache.org>.
jonyangx commented on issue #2729:
URL: https://github.com/apache/incubator-eventmesh/issues/2729#issuecomment-1368327227
I want to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org