You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/05/03 18:12:18 UTC
Review Request 58970: Repositories must be resolved correctly when
installing new components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-20923
https://issues.apache.org/jira/browse/AMBARI-20923
Repository: ambari
Description
-------
When formulating commands to agents, the correct repositories need to be used for the components. For example, after a cluster is patched, the following repos could exist:
||Service||Component||Repository||
|HDFS |NN| 2.5.0.0|
|HDFS |DN| 2.5.0.0|
|YARN |RM| 2.5.0.1|
|YARN |NM| 2.5.0.1|
When installing an additional NM, the 2.5.0.1 repository should be used.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 0dd9c02d40
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 849d6fba42
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java bd62cbbd52
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d6905fb7a4
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8995e51987
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java eb1b187459
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java b0d085b942
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 0a583aeea9
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5206ea351c
Diff: https://reviews.apache.org/r/58970/diff/1/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 58970: Repositories must be resolved correctly when
installing new components
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/#review173776
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 3, 2017, 6:12 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58970/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 6:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-20923
> https://issues.apache.org/jira/browse/AMBARI-20923
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When formulating commands to agents, the correct repositories need to be used for the components. For example, after a cluster is patched, the following repos could exist:
> ||Service||Component||Repository||
> |HDFS |NN| 2.5.0.0|
> |HDFS |DN| 2.5.0.0|
> |YARN |RM| 2.5.0.1|
> |YARN |NM| 2.5.0.1|
>
> When installing an additional NM, the 2.5.0.1 repository should be used.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 0dd9c02d40
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 849d6fba42
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java bd62cbbd52
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d6905fb7a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8995e51987
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java eb1b187459
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java b0d085b942
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 0a583aeea9
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5206ea351c
>
>
> Diff: https://reviews.apache.org/r/58970/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 58970: Repositories must be resolved correctly when
installing new components
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 3, 2017, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> > Lines 1373-1376 (patched)
> > <https://reviews.apache.org/r/58970/diff/1/?file=1707187#file1707187line1376>
> >
> > This lookup is a DB-hit ... Instead, you can use the new `getDesiredRepositoryVersion()` method off of the ServiceComponent
Will do - this must have been added with your recent patch as I didn't have that method before.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/#review173787
-----------------------------------------------------------
On May 3, 2017, 2:12 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58970/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 2:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-20923
> https://issues.apache.org/jira/browse/AMBARI-20923
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When formulating commands to agents, the correct repositories need to be used for the components. For example, after a cluster is patched, the following repos could exist:
> ||Service||Component||Repository||
> |HDFS |NN| 2.5.0.0|
> |HDFS |DN| 2.5.0.0|
> |YARN |RM| 2.5.0.1|
> |YARN |NM| 2.5.0.1|
>
> When installing an additional NM, the 2.5.0.1 repository should be used.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 0dd9c02d40
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 849d6fba42
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java bd62cbbd52
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d6905fb7a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8995e51987
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java eb1b187459
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java b0d085b942
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 0a583aeea9
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5206ea351c
>
>
> Diff: https://reviews.apache.org/r/58970/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 58970: Repositories must be resolved correctly when
installing new components
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58970/#review173787
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Lines 1373-1376 (patched)
<https://reviews.apache.org/r/58970/#comment246820>
This lookup is a DB-hit ... Instead, you can use the new `getDesiredRepositoryVersion()` method off of the ServiceComponent
- Jonathan Hurley
On May 3, 2017, 2:12 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58970/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 2:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-20923
> https://issues.apache.org/jira/browse/AMBARI-20923
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When formulating commands to agents, the correct repositories need to be used for the components. For example, after a cluster is patched, the following repos could exist:
> ||Service||Component||Repository||
> |HDFS |NN| 2.5.0.0|
> |HDFS |DN| 2.5.0.0|
> |YARN |RM| 2.5.0.1|
> |YARN |NM| 2.5.0.1|
>
> When installing an additional NM, the 2.5.0.1 repository should be used.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 0dd9c02d40
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 849d6fba42
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java bd62cbbd52
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d6905fb7a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8995e51987
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java eb1b187459
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java b0d085b942
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 0a583aeea9
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5206ea351c
>
>
> Diff: https://reviews.apache.org/r/58970/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>