You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/04 11:06:09 UTC

[GitHub] [cordova-plugin-file] merrygobyebye opened a new pull request #236: fix(android): Use cdvPluginPostBuildExtras instead of ext.postBuildExtras (CB-14163)

merrygobyebye opened a new pull request #236: fix(android): Use cdvPluginPostBuildExtras instead of ext.postBuildExtras (CB-14163)
URL: https://github.com/apache/cordova-plugin-file/pull/236
 
 
   # Use cdvPluginPostBuildExtras instead of ext.postBuildExtras
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   1. Adds a reference to the `build-extras.gradle` file in `plugin.xml` so that the code in `build-extras.gradle` will run with the main Cordova `build.gradle`.
   2. Replaces incorrect usage of `ext.postBuildExtras` with usage of `cdvPluginPostBuildExtras`.
   
   ### What testing has been done on this change?
   Added the modified cordova-plugin-file to a Cordova project and verified that the code in `build-extras.gradle` ran during the execution of the command `cordova build android`.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org