You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2025/02/24 08:41:58 UTC

[I] Support `interleave` kernel with deep copy buffers for `StringViewArray` [arrow-rs]

2010YOUY01 opened a new issue, #7184:
URL: https://github.com/apache/arrow-rs/issues/7184

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   https://github.com/apache/arrow-rs/blob/a0c3186c55ac8ed3f6b8a15d1305548fd6305ebb/arrow-select/src/interleave.rs#L238
   Current implementation of `interleave` kernel on `StringViewArray` reuses the existing buffers from source arrays, it's only reconstructing `view`s specified by the interleaving operation. It's useful to also support `interleave` by reconstructing buffers. (For example, if the referenced elements are sparse)
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   Provides an additional interface for `StringViewArray` to do `interleave` with deep copy buffers.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support `interleave` kernel with deep copy buffers for `StringViewArray` [arrow-rs]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on issue #7184:
URL: https://github.com/apache/arrow-rs/issues/7184#issuecomment-2677786960

   > I wonder if instead of baking this into the interleave kernel, and potentially others besides, it would be better for applications to call https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericByteViewArray.html#method.gc when appropriate?
   > 
   > This would have a number of advantages:
   > 
   > * Don't need to modify multiple kernels
   > * Applications can chain kernels and only perform GC once at the end
   > * Applications are in control of any heuristics as to when this should take place
   
   Thanks for the perspectives. We're currently using `gc()`. Performing the copy within the interleave kernel is just slightly more efficient. 
   If adding an additional interface inside `arrow` isn't ideal, we can implement this fused logic at the application level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support `interleave` kernel with deep copy buffers for `StringViewArray` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #7184:
URL: https://github.com/apache/arrow-rs/issues/7184#issuecomment-2683109113

   Related :
   - https://github.com/apache/arrow-rs/issues/7151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support `interleave` kernel with deep copy buffers for `StringViewArray` [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #7184:
URL: https://github.com/apache/arrow-rs/issues/7184#issuecomment-2677762926

   I wonder if instead of baking this into the interleave kernel, it would be better for applications to call https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericByteViewArray.html#method.gc when appropriate?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org