[GitHub] flink pull request #5492: [FLINK-5728] [kafka] Let FlinkKafkaProducers flush...

[tzulitai <gi...@git.apache.org>]

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/5492

    [FLINK-5728] [kafka] Let FlinkKafkaProducers flush on checkpoints by default

    ## What is the purpose of the change
    
    This pull request makes flushing on checkpoints in the Kafka producer the default behaviour.
    Effectively, the user now should not require any additional configuration for the producer to have at-least-once semantics.
    
    ## Brief change log
    
    - initialize `flushOnCheckpoint` flag to be `true`
    - update documents
    
    ## Verifying this change
    
    Existing tests should already cover this change.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-5728

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5492
    
----
commit fd63de1dfbaeb01dc78254bf6a9e549efcffb7b9
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-02-15T08:12:22Z

    [FLINK-5728] [kafka] Let FlinkKafkaProducers flush on checkpoints by default

----


---

[GitHub] flink pull request #5492: [FLINK-5728] [kafka] Let FlinkKafkaProducers flush...

[tzulitai <gi...@git.apache.org>]

Github user tzulitai closed the pull request at:

    https://github.com/apache/flink/pull/5492


---

[GitHub] flink issue #5492: [FLINK-5728] [kafka] Let FlinkKafkaProducers flush on che...

[aljoscha <gi...@git.apache.org>]

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5492
  
    Had to change this line to use `StreamingRuntimeContext.class` because the Producer would now actually call this: https://github.com/apache/flink/blob/96e898f2923f6b68bc845facf9c2d7ce1a951bbb/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java#L100 😅 


---

[GitHub] flink issue #5492: [FLINK-5728] [kafka] Let FlinkKafkaProducers flush on che...

[aljoscha <gi...@git.apache.org>]

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5492
  
    LGTM! I will merge as soon as travis is green



---

[GitHub] flink issue #5492: [FLINK-5728] [kafka] Let FlinkKafkaProducers flush on che...

[aljoscha <gi...@git.apache.org>]

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5492
  
    I merged this, could you please close the PR? 👍 


---