You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/28 17:12:48 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5227: [AIRFLOW-4454] Add support for lifecycle events in kubernetes pod operator

ashb commented on a change in pull request #5227: [AIRFLOW-4454] Add support for lifecycle events in kubernetes pod operator
URL: https://github.com/apache/airflow/pull/5227#discussion_r288211536
 
 

 ##########
 File path: docs/kubernetes.rst
 ##########
 @@ -126,6 +126,19 @@ Kubernetes Operator
          }
     ]
 
+    life_cycle = {
+      'postStart': {
 
 Review comment:
   Dunno - it's probably easiest if we mirror the Kube YAML structure isn't it? One less thing to learn, and we can point at the Kube docs rather than having to write our own?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services