You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 02:24:48 UTC
[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel
cyb70289 commented on a change in pull request #8637:
URL: https://github.com/apache/arrow/pull/8637#discussion_r521776788
##########
File path: docs/source/cpp/compute.rst
##########
@@ -140,7 +140,7 @@ Aggregations
+--------------------------+------------+--------------------+-----------------------+--------------------------------------------+
| min_max | Unary | Numeric | Scalar Struct (1) | :struct:`MinMaxOptions` |
+--------------------------+------------+--------------------+-----------------------+--------------------------------------------+
-| mode | Unary | Numeric | Scalar Struct (2) | |
+| mode | Unary | Numeric | Scalar Struct (2) | :struct:`ModeOptions` |
Review comment:
Mode now returns an array of struct. Should it be "Struct Array"? or simply "Struct'.
Should I also change above line (min_max) to "Struct"? or leave it "Scalar Struct".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org