You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/21 19:10:50 UTC

[GitHub] [pulsar] srkukarni commented on pull request #7010: Fix null pointer when getting function instance metrics.

srkukarni commented on pull request #7010:
URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632290148


   @jerrypeng 
   1. Some methods are updating multiple counters/gauages. That still has to be in sync block to ensure that we get consistent stats
   2. The fact that today this class is using an already thread safe data structure is merely detail. If for whatever reason we switch it to some other impl, the methods should still be thread safe. Thus don;t you think its better to declare the methods synchronized explicitly?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org