Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Brian Pane <bp...@pacbell.net>]

On Wed, 2002-06-12 at 23:36, jerenkrantz@apache.org wrote:
> jerenkrantz    2002/06/12 23:36:40
> 
>   Modified:    .        CHANGES
>                modules/generators mod_cgi.c
>   Log:
>   Per RFC 2616 section 9.4, we SHOULD return the content-length if possible on
>   HEAD requests (even for CGI requests).  Also do it because it fixes the cause
>   of .37's demise.
>   
>   This also fixes a condition seen on FreeBSD-4.6 where HEAD requests on CGI
>   scripts would hang because the OS would return EAGAIN in log_script_err
>   (via apr_file_gets).  Since we never read the script output, this caused
>   FreeBSD to not let us read stderr.

Thanks for the quick fix.  Time for a 2.0.38 release?

--Brian

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Justin Erenkrantz <je...@apache.org>]

On Thu, Jun 13, 2002 at 01:01:40PM -0700, Greg Stein wrote:
> mod_dav also checks the header_only flag.
> 
> Should that flag simply be deprecated/removed ?

+1.  My take is that only the HTTP header output filter needs to
know about HEAD.  Everybody else should treat HEAD as identical to
GET.  -- justin

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Greg Stein <gs...@lyra.org>]

On Thu, Jun 13, 2002 at 11:36:06AM -0700, Brian Pane wrote:
> Cliff Woolley wrote:
> >On Thu, 13 Jun 2002, Aaron Bannert wrote:
> >>On Thu, Jun 13, 2002 at 09:26:27AM -0700, Brian Pane wrote:
> >>>Thanks for the quick fix.  Time for a 2.0.38 release?
> >>>      
> >>
> >>+1
> >
> >We need to check all of our handlers for this, and we need to remove the
> >comment in the core that continues to say that handlers are broken if they
> >send down the body for a headers_only request.
> 
> Does mod_cgid need the same change?

mod_dav also checks the header_only flag.

Should that flag simply be deprecated/removed ?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Brian Pane <br...@cnet.com>]

Cliff Woolley wrote:

>On Thu, 13 Jun 2002, Aaron Bannert wrote:
>
>  
>
>>On Thu, Jun 13, 2002 at 09:26:27AM -0700, Brian Pane wrote:
>>    
>>
>>>Thanks for the quick fix.  Time for a 2.0.38 release?
>>>      
>>>
>>+1
>>    
>>
>
>We need to check all of our handlers for this, and we need to remove the
>comment in the core that continues to say that handlers are broken if they
>send down the body for a headers_only request.
>  
>

Does mod_cgid need the same change?

mod_cgid.c:1237:
        if (!r->header_only) {
            /* Passing our socket down the filter chain in a pipe bucket
             * gives up the responsibility of closing the socket, so
             * get rid of the cleanup.
             */
            apr_pool_cleanup_kill(r->pool, (void *)sd, close_unix_socket);

            ap_pass_brigade(r->output_filters, bb);
        }

--Brian

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Cliff Woolley <jw...@virginia.edu>]

On Thu, 13 Jun 2002, Cliff Woolley wrote:

> What about the HEAD thing?  Are we *sure* we can blame it on FreeBSD's
> new release?  Shouldn't we account for it somehow?

Oh, I guess I didn't read the whole log message.  Nevermind on this part.

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Cliff Woolley <jw...@virginia.edu>]

On Thu, 13 Jun 2002, Aaron Bannert wrote:

> On Thu, Jun 13, 2002 at 09:26:27AM -0700, Brian Pane wrote:
> > Thanks for the quick fix.  Time for a 2.0.38 release?
>
> +1

We need to check all of our handlers for this, and we need to remove the
comment in the core that continues to say that handlers are broken if they
send down the body for a headers_only request.

What about the HEAD thing?  Are we *sure* we can blame it on FreeBSD's
new release?  Shouldn't we account for it somehow?

--Cliff

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

[Aaron Bannert <aa...@clove.org>]

On Thu, Jun 13, 2002 at 09:26:27AM -0700, Brian Pane wrote:
> Thanks for the quick fix.  Time for a 2.0.38 release?

+1

-aaron