You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/08/02 15:59:29 UTC
[GitHub] mitchell852 commented on a change in pull request #2609: Manage
Static DNS Entries - front end CRUD implementation
mitchell852 commented on a change in pull request #2609: Manage Static DNS Entries - front end CRUD implementation
URL: https://github.com/apache/trafficcontrol/pull/2609#discussion_r207282464
##########
File path: traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go
##########
@@ -81,13 +81,27 @@ func (staticDNSEntry *TOStaticDNSEntry) SetKeys(keys map[string]interface{}) {
// Validate fulfills the api.Validator interface
func (staticDNSEntry TOStaticDNSEntry) Validate() error {
- if _, err := tc.ValidateTypeID(staticDNSEntry.ReqInfo.Tx.Tx, &staticDNSEntry.TypeID, "staticdnsentry"); err != nil {
+ typeStr, err := tc.ValidateTypeID(staticDNSEntry.ReqInfo.Tx.Tx, &staticDNSEntry.TypeID, "staticdnsentry");
+ if err != nil {
return err
}
+ addressErr := error(nil)
Review comment:
this part seems odd to be in this PR. was this the result of a merge or rebase or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services